Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit event when failing to update a taskrun #2522

Closed
afrittoli opened this issue May 1, 2020 · 1 comment
Closed

Emit event when failing to update a taskrun #2522

afrittoli opened this issue May 1, 2020 · 1 comment
Assignees
@afrittoli
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@afrittoli
Copy link
Member

Expected Behavior

When the taskrun controller fails to update a taskrun status or labels/annotations, it should emit an event to signal this condition, similar to what the pipelinerun controller does.

Actual Behavior

An error is returned, so that the key is requeued, but not event is emitted.

Steps to Reproduce the Problem

  1. pipeline/pkg/reconciler/taskrun/taskrun.go

    Line 208 in b435bd9

    return multierror.Append(err, c.updateStatusLabelsAndAnnotations(tr, original)).ErrorOrNil()

Additional Info

  • Tekton Pipeline version:

v0.12.0
@afrittoli afrittoli added the kind/feature Categorizes issue or PR as related to a new feature. label May 1, 2020
@afrittoli afrittoli self-assigned this May 1, 2020
@afrittoli
Copy link
Member Author

Fixed by #2526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afrittoli afrittoli

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afrittoli