The tekton.dev/conditionCheck contains the TaskRun names insteaf of the check name

[afrittoli]

Expected Behavior

The tekton.dev/conditionCheck attached to the underlying TaskRun should contain the name of the Condition from which it was generated.

Actual Behavior

It contains instead the name of the TaskRun itself.

Steps to Reproduce the Problem

1. Run a pipeline with conditions. Check the taskrun associated to the condition.

apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  annotations:
    pipeline.tekton.dev/release: devel
    tekton.dev/gitURL: https://github.com/tektoncd/plumbing
  creationTimestamp: "2020-04-09T14:05:58Z"
  generation: 1
  labels:
    app.kubernetes.io/managed-by: tekton-pipelines
    prow.k8s.io/build-id: 3c4d2700-7a6b-11ea-9e53-9cd5bca4ea86
    tekton.dev/check-name: tekton-noop-check
    tekton.dev/conditionCheck: tekton-noop-check-nt8dq-check-reset-9pq8r-check-git-files-5sst4
    tekton.dev/kind: ci
    tekton.dev/pipeline: tekton-noop-check
    tekton.dev/pipelineRun: tekton-noop-check-nt8dq
    tekton.dev/pipelineTask: check-reset
    tekton.dev/pr-number: "313"
    triggers.tekton.dev/eventlistener: tekton-ci-webhook
    triggers.tekton.dev/trigger: pull-request-trigger
    triggers.tekton.dev/triggers-eventid: gfzzl
  name: tekton-noop-check-nt8dq-check-reset-9pq8r-check-git-files-5sst4
  namespace: tektonci
  ownerReferences:
  - apiVersion: tekton.dev/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: PipelineRun
    name: tekton-noop-check-nt8dq
    uid: ed823ea2-0358-4b9d-bc94-0dbd8fa0f0ba
  resourceVersion: "75130429"
  selfLink: /apis/tekton.dev/v1beta1/namespaces/tektonci/taskruns/tekton-noop-check-nt8dq-check-reset-9pq8r-check-git-files-5sst4
  uid: b2838691-2240-40a6-b26f-b3b5ea2cc389

Additional Info

• Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T23:41:55Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.9-gke.24", GitCommit:"39e41a8d6b7221b901a95d3af358dea6994b4a40", GitTreeState:"clean", BuildDate:"2020-02-29T01:24:35Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"}

- Tekton Pipeline version:

Client version: 0.8.0
Pipeline version: v0.11.1

<!-- Any other additional information -->

[afrittoli]

Fixed by #2579