Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kubernetes dependencies to 0.19.2 #3324

Closed
rawlingsj opened this issue Oct 2, 2020 · 6 comments
Closed

Upgrade Kubernetes dependencies to 0.19.2 #3324

rawlingsj opened this issue Oct 2, 2020 · 6 comments
Labels
area/dependency Issues or PRs related to dependency changes kind/question Issues or PRs that are questions around the project or a particular feature

Comments

@rawlingsj
Copy link
Contributor

rawlingsj commented Oct 2, 2020

We're using the Tekton client in a couple of places and are currently upgrading all our golang Kubernetes dependencies to 0.19.2. This includes an upgraded Kubernetes client-go which requires fixing up code due to breaking API changes.

I've just noticed there's a similar PR #3319 although that doesn't go all the way to 0.19.2 so I wonder if we should combine the two efforts or keep them separate?

Right now I have made these changes on a fork https://github.com/rawlingsj/pipeline/tree/k8s_0.19.2

I'm not sure I've done everything that's needed to upgrade:

A couple of questions

  1. Not sure if there are other steps that are needed above?
  2. Did you want a PR for these changes and if so should I look to combine with Upgrade knative -> 0.18 #3319 or just keep them separate?
@jerop
Copy link
Member

jerop commented Oct 5, 2020

/kind question
/priority backlog (owners will review)
/area dependency

@tekton-robot tekton-robot added kind/question Issues or PRs that are questions around the project or a particular feature priority/backlog Higher priority than priority/awaiting-more-evidence. area/dependency Issues or PRs related to dependency changes labels Oct 5, 2020
@ghost ghost added this to the Pipelines v0.18 milestone Oct 5, 2020
@afrittoli
Copy link
Member

afrittoli commented Oct 19, 2020

Does this require an update to the minimum version?
In case we need to document the min version required for Tekton.

@afrittoli afrittoli removed the priority/backlog Higher priority than priority/awaiting-more-evidence. label Oct 19, 2020
@ghost
Copy link

ghost commented Jan 25, 2021

It looks as though this will happen naturally when we upgrade to knative 0.21.

@dprotaso
Copy link
Contributor

The above PR bumped the k8s deps

@dprotaso
Copy link
Contributor

Right now knative.dev/pkg is tracking the main branch instead of the 0.20 release.

@afrittoli
Copy link
Member

This is closed by #3724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes kind/question Issues or PRs that are questions around the project or a particular feature
Projects
None yet
Development

No branches or pull requests

6 participants