Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/pull_request_template.md should include /kind #3397

Closed
mattmoor opened this issue Oct 15, 2020 · 0 comments · Fixed by #3409
Closed

.github/pull_request_template.md should include /kind #3397

mattmoor opened this issue Oct 15, 2020 · 0 comments · Fixed by #3409
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mattmoor
Copy link
Member

Expected Behavior

PR template prompts folks to do all required things.

Actual Behavior

/kind is missing

Steps to Reproduce the Problem

  1. Open a PR,
  2. Don't do anything extra,
  3. See the /kind label checker fail
  4. Be sad.
@mattmoor mattmoor added the kind/bug Categorizes issue or PR as related to a bug. label Oct 15, 2020
jerop added a commit to jerop/pipeline that referenced this issue Oct 19, 2020
@jerop
Add kind label to pull request template
18eeaab 
Currently, the template doesn't prompt contributors to add the kind
label. So many times the check fails and user has to add it after
getting the test for kind label fails.

This change ensures that the PR template prompts contributors to do all
the required tasks.

Fixes tektoncd#3397
@jerop jerop mentioned this issue Oct 19, 2020
Merged
4 tasks
tekton-robot pushed a commit that referenced this issue Oct 20, 2020
@jerop @tekton-robot
Add kind label to pull request template
50b6f91 
Currently, the template doesn't prompt contributors to add the kind
label. So many times the check fails and user has to add it after
getting the test for kind label fails.

This change ensures that the PR template prompts contributors to do all
the required tasks.

Fixes #3397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add kind label to pull request template jerop/pipeline
1 participant
@mattmoor