Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request to detect whether executed TaskRun is part of finally section #3721

Closed
anshulpatel25 opened this issue Jan 27, 2021 · 5 comments · Fixed by #4121
Closed

Feature request to detect whether executed TaskRun is part of finally section #3721

anshulpatel25 opened this issue Jan 27, 2021 · 5 comments · Fixed by #4121
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@anshulpatel25
Copy link

Feature request

Ability to fetch/differentiate TaskRuns executed as part of Finally section in the PipelineRun

Use case

Currently, there is no way to detect whether executed TaskRun is part of Finally section directly. Adding this feature can help external systems via SDK to directly query the TaskRuns which are part of Finally without applying complex logic.

@anshulpatel25 anshulpatel25 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 27, 2021
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2021
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2021
@ghost
Copy link

ghost commented Jun 15, 2021

/assign @pritidesai

@vdemeester
Copy link
Member

/lifecycle frozen
We could add a label to the taskrun (and thus the pod too) when it's a finally one, right ?

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jun 17, 2021
@pritidesai
Copy link
Member

/lifecycle frozen
We could add a label to the taskrun (and thus the pod too) when it's a finally one, right ?

yes, that would be the best way, I will have a PR with changes in a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants