-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI about to fail due to build-crd-testing deletion #4220
Comments
Agreed 😅 What was the "secret sauce" doing ? I guess only used as a private image to exercise the auth ? |
Yup, private image auth test |
I'm gonna downgrade the priority on this one since @vdemeester has at least made it so this won't block folks |
/assign |
/cc @sbwsg |
One of the tricky parts here is that GCR only supports ACL at the registry level, so we either need to use an existing private registry we have in a project or create a new project explicitly for testing this out. The Edit: also added this to discussion for next Pipelines WG to keep the convo moving forward. |
I'd recommend against using My preference would be to use a new project and/or use Artifact Registry which has finer ACLs than GCR. |
@afrittoli is working on running tests in Kind and with this it should be possible to setup a registry with credentials for testing purposes. From Pipelines WG just now this would be preferable over maintaining a piece of cloud infra specific to tests so that's the approach we intend to pursue before committing to a new GCP project, Artifact Registry or similar. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/lifecycle frozen |
@mattmoor pointed out that the GCP project
build-crd-testing
has been deleted; we have a bunch of examples which reference this project (e.g.pipeline/examples/v1beta1/taskruns/pull-private-image.yaml
Line 50 in bda40ea
pipeline/test/pipelinerun_test.go
Line 696 in bda40ea
We'll need to update these examples and tests to use a project that actually exists (e.g. one of these https://github.com/tektoncd/plumbing/blob/main/docs/README.md#gcp-projects); in the meantime it might be best to disable these if they start blocking PRs.
The text was updated successfully, but these errors were encountered: