Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI about to fail due to build-crd-testing deletion #4220

Open
bobcatfish opened this issue Sep 7, 2021 · 10 comments
Open

CI about to fail due to build-crd-testing deletion #4220

bobcatfish opened this issue Sep 7, 2021 · 10 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@bobcatfish
Copy link
Collaborator

@mattmoor pointed out that the GCP project build-crd-testing has been deleted; we have a bunch of examples which reference this project (e.g.

script: skopeo copy docker://gcr.io/build-crd-testing/secret-sauce dir:///tmp/
) and we also use it in an end to end test (
Value: *v1beta1.NewArrayOrString("docker://gcr.io/build-crd-testing/secret-sauce"),
).

We'll need to update these examples and tests to use a project that actually exists (e.g. one of these https://github.com/tektoncd/plumbing/blob/main/docs/README.md#gcp-projects); in the meantime it might be best to disable these if they start blocking PRs.

@bobcatfish bobcatfish added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Sep 7, 2021
@vdemeester
Copy link
Member

Agreed 😅 What was the "secret sauce" doing ? I guess only used as a private image to exercise the auth ?

@mattmoor
Copy link
Member

mattmoor commented Sep 8, 2021

Yup, private image auth test

@bobcatfish
Copy link
Collaborator Author

I'm gonna downgrade the priority on this one since @vdemeester has at least made it so this won't block folks

@bobcatfish bobcatfish added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Sep 9, 2021
@vdemeester
Copy link
Member

/assign

@bobcatfish bobcatfish added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 18, 2021
@dibyom
Copy link
Member

dibyom commented Nov 29, 2021

/cc @sbwsg

@ghost
Copy link

ghost commented Dec 13, 2021

One of the tricky parts here is that GCR only supports ACL at the registry level, so we either need to use an existing private registry we have in a project or create a new project explicitly for testing this out.

The tekton-nightly project has existing private registries set up for eu.gcr.io, us.gcr.io and asia.gcr.io. We could use one of these? @tektoncd/core-maintainers wdyt?

Edit: also added this to discussion for next Pipelines WG to keep the convo moving forward.

@wlynch
Copy link
Member

wlynch commented Dec 14, 2021

I'd recommend against using tekton-nightly out of paranoia that tests might gain unintended access to other dogfooding resources.

My preference would be to use a new project and/or use Artifact Registry which has finer ACLs than GCR.

@ghost
Copy link

ghost commented Dec 14, 2021

@afrittoli is working on running tests in Kind and with this it should be possible to setup a registry with credentials for testing purposes. From Pipelines WG just now this would be preferable over maintaining a piece of cloud infra specific to tests so that's the approach we intend to pursue before committing to a new GCP project, Artifact Registry or similar.

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022
@vdemeester
Copy link
Member

/lifecycle frozen
/assign @afrittoli

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 11, 2022
@vdemeester vdemeester removed their assignment Oct 18, 2022
@vdemeester vdemeester added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
Status: Todo
Development

No branches or pull requests

7 participants