Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying resource requests at the TaskRun level #4326

Closed
jsravn opened this issue Oct 21, 2021 · 6 comments · Fixed by #4598
Closed

Support specifying resource requests at the TaskRun level #4326

jsravn opened this issue Oct 21, 2021 · 6 comments · Fixed by #4598
Assignees
@lbernick
Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jsravn
Copy link

jsravn commented Oct 21, 2021 •
edited
Loading

Feature request

Currently resource requests can only be done at the Task level. However this is limiting when trying to reuse generic tasks. It would make more sense to me to have resources specified in the TaskRun, with the Task providing a set of defaults.

Use case

An example that came up recently is using the kaniko hub task. The resources required will vary widely based on the contents of the Dockerfile. As is, I have to redefine this Task based on each build, making the shared task fairly useless.

Possibly related to #2986.
@jsravn jsravn added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 21, 2021
@lbernick
Copy link
Member

lbernick commented Nov 2, 2021

Hi @jsravn, I think this use case would be addressed by #4080, which I'm currently working on, so I'm going to close this as a duplicate issue. Please feel free to reopen if needed.

triage/duplicate
/close

@tekton-robot
Copy link
Collaborator

@lbernick: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

Hi @jsravn, I think this use case would be addressed by #4080, which I'm currently working on, so I'm going to close this as a duplicate issue. Please feel free to reopen if needed.

triage/duplicate
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

vdemeester commented Nov 2, 2021 •
edited
Loading

Hi @jsravn, I think this use case would be addressed by #4080, which I'm currently working on, so I'm going to close this as a duplicate issue. Please feel free to reopen if needed.

triage/duplicate /close

Although it might be addressed by #4080, I wonder if it should be the way it gets solved. For example, I want to use a Task from the Hub/Catalog, where I do not have any control, and this Task doesn't have any parametrized resource limits/requirements setup, then I want to be able to provide this at runtime.
@lbernick Hence I would like to keep this one open for now 👼🏼

@lbernick lbernick mentioned this issue Nov 3, 2021
Open
@lbernick
Copy link
Member

lbernick commented Nov 8, 2021

/assign

@jsravn
Copy link
Author

jsravn commented Nov 8, 2021

I agree that it makes sense to do this generically at the TaskRun level. I think conceptually it makes sense to consider resources as an instance/run level attribute rather than that of the task.

lbernick added a commit to lbernick/community that referenced this issue Nov 8, 2021
@lbernick
[Problem Statement] TEP for specifying resource requirements at runtime
9d4bc9e 
This TEP addresses tektoncd/pipeline#4080 and tektoncd/pipeline#4326 by
proposing new configuration to TaskRuns and PipelineTaskRuns that can
override any Step resource requirements specified in a Task or PipelineTask.
@lbernick lbernick mentioned this issue Nov 8, 2021
Merged
lbernick added a commit to lbernick/community that referenced this issue Nov 8, 2021
@lbernick
[Problem Statement] TEP for specifying resource requirements at runtime
a7aec07 
This TEP addresses tektoncd/pipeline#4080 and tektoncd/pipeline#4326 by
proposing new configuration to TaskRuns and PipelineTaskRuns that can
override any Step resource requirements specified in a Task or PipelineTask.
lbernick added a commit to lbernick/community that referenced this issue Nov 8, 2021
@lbernick
[Problem Statement] TEP for specifying resource requirements at runtime
b70e85d 
This TEP addresses tektoncd/pipeline#4080 and tektoncd/pipeline#4326 by
proposing new configuration to TaskRuns and PipelineTaskRuns that can
override any Step resource requirements specified in a Task or PipelineTask.
lbernick added a commit to lbernick/community that referenced this issue Nov 8, 2021
@lbernick
[Problem Statement] TEP for specifying resource requirements at runtime
709d722 
This TEP addresses tektoncd/pipeline#4080 and tektoncd/pipeline#4326 by
proposing new configuration to TaskRuns and PipelineTaskRuns that can
override any Step resource requirements specified in a Task or PipelineTask.
lbernick added a commit to lbernick/community that referenced this issue Nov 8, 2021
@lbernick
[Problem Statement] TEP for specifying resource requirements at runtime
50487c6 
This TEP addresses tektoncd/pipeline#4080 and tektoncd/pipeline#4326 by
proposing new configuration to TaskRuns and PipelineTaskRuns that can
override any Step resource requirements specified in a Task or PipelineTask.
lbernick added a commit to lbernick/community that referenced this issue Nov 9, 2021
@lbernick
[Problem Statement] TEP for specifying resource requirements at runtime
4babc84 
This TEP addresses tektoncd/pipeline#4080 and tektoncd/pipeline#4326 by
proposing new configuration to TaskRuns and PipelineTaskRuns that can
override any Step resource requirements specified in a Task or PipelineTask.
lbernick added a commit to lbernick/community that referenced this issue Nov 10, 2021
@lbernick
[Problem Statement] TEP for specifying resource requirements at runtime
933bf0b 
This TEP addresses tektoncd/pipeline#4080 and tektoncd/pipeline#4326 by
proposing new configuration to TaskRuns and PipelineTaskRuns that can
override any Step resource requirements specified in a Task or PipelineTask.
tekton-robot pushed a commit to tektoncd/community that referenced this issue Nov 12, 2021
@lbernick @tekton-robot
[Problem Statement] TEP for specifying resource requirements at runtime
cb58513 
This TEP addresses tektoncd/pipeline#4080 and tektoncd/pipeline#4326 by
proposing new configuration to TaskRuns and PipelineTaskRuns that can
override any Step resource requirements specified in a Task or PipelineTask.
@lbernick
Copy link
Member

Sorry this took some time, but TEP-0094: Configuring Resources at Runtime is now implementable.

@lbernick lbernick mentioned this issue Feb 14, 2022
Merged
5 tasks
@jerop jerop added the area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) label Feb 17, 2022
@jerop jerop moved this to In Progress in Tekton Pipelines Roadmap Feb 17, 2022
This was referenced Feb 18, 2022
Merged
Merged
Repository owner moved this from In Progress to Done in Tekton Pipelines Roadmap Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbernick lbernick

Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature.
Projects
Tekton Pipelines Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Step and Sidecar Overrides for TaskRun lbernick/pipeline
5 participants
@vdemeester @jsravn @jerop @lbernick @tekton-robot