Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order TaskRun.Status.Steps same way as Task.Spec.Steps #942

Closed
vdemeester opened this issue Jun 4, 2019 · 2 comments · Fixed by #963
Closed

Order TaskRun.Status.Steps same way as Task.Spec.Steps #942

vdemeester opened this issue Jun 4, 2019 · 2 comments · Fixed by #963
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vdemeester
Copy link
Member

Related to #818 (comment), the TaskRun.Status.Steps order is not the same as Task.Spec.Steps, as @hrishin commented.

yeah its because of taskrun reconciler copies the pod.status.containerStatus for all steps. By default, k8s sort the containerStatus in alphabetically sorted order (which is wired don't know why).

While working on fetching the task logs, one has to either iterate through pod.status.containerStatus or TaskRun.Status.Steps. Now the issue is, steps order is not maintained anymore, it has to find the currently running container and rather simply iterate over taskrun.status.steps while printing the logs.

We feel it would be better if the order would be kept, to simplify iterating over the status and also because as a user it feels a bit weird to see status in a different order.

cc @hrishin @bobcatfish

/kind enhancement

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 4, 2019
@vdemeester vdemeester added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jun 4, 2019
@hrishin
Copy link
Member

hrishin commented Jun 4, 2019

Thank you! @vdemeester 👍

@bobcatfish bobcatfish added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 4, 2019
@houshengbo
Copy link

/assign @houshengbo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants