Fix Pipeline error with ClusterTasks #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to use `ClusterTask` in a Pipeline, for that you specify that the `Task` you want to use is of type `ClusterTask` (default being `Task`). But, before this change, the `PipelineRun` using this `Pipeline` would fail as the `Kind` information is not passed from the `PipelineTask.TaskRef` to the actual `TaskRun`. This fixes that by passing the `Kind` of a `TaskRef` when resolving the `Task`/`TaskRun` in the `PipelineRun` reconcilier. A yaml test is added as a regression test. Signed-off-by: Vincent Demeester <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
tekton-robot
added
approved
|
/test pull-tekton-pipeline-integration-tests |
|
/test pull-tekton-pipeline-go-coverage |
1 similar comment
|
/test pull-tekton-pipeline-go-coverage |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It is possible to use
ClusterTaskin a Pipeline, for that youspecify that the
Taskyou want to use is of typeClusterTask(default beingTask). But, before this change, thePipelineRunusing thisPipelinewould fail as theKindinformation is not passed from the
PipelineTask.TaskRefto theactual
TaskRun.This fixes that by passing the
Kindof aTaskRefwhen resolvingthe
Task/TaskRunin thePipelineRunreconcilier.A yaml test is added as a regression test.
Fixes #1001 — thanks for the report @steveodonovan
/cc @bobcatfish
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes