From 7c02e2e9901491770acec94694e44c68d937db4c Mon Sep 17 00:00:00 2001 From: Dibyo Mukherjee Date: Mon, 29 Jul 2019 12:02:58 -0400 Subject: [PATCH] Update docs with additional steps for adding new types Signed-off-by: Dibyo Mukherjee --- DEVELOPMENT.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index ea5e4268623..4644dcdb21c 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -270,7 +270,13 @@ To look at the logs for individual `TaskRuns` or `PipelineRuns`, see If you need to add a new CRD type, you will need to add: 1. A yaml definition in [config/](./config) -1. Add the type to the cluster roles in - [200-clusterrole.yaml](./config/200-clusterrole.yaml) +1. Add the type to the cluster roles in: + - [200-clusterrole.yaml](./config/200-clusterrole.yaml) + - [clusterrole-aggregate-edit.yaml](./config/clusterrole-aggregate-edit.yaml) + - [clusterrole-aggregate-view.yaml](./config/clusterrole-aggregate-view.yaml) +1. Add go structs for the types in [pkg/apis/pipelines/v1alpha1](./pkg/apis/pipeline/v1alpha1) + e.g [condition_types.go](./pkg/apis/pipeline/v1alpha1/condition_types.go) +1. Register it with the [webhook](./cmd/webhook/main.go) +1. Add the new type to the [list of known types](./pkg/apis/pipeline/v1alpha1/register.go) _See [the API compatibility policy](api_compatibility_policy.md)._