Readd mounting volumes in workingdir

[chmouel]

Mounting volume was dropped when we did the large refactoring in
d7f492c which basically making
it ineffective and fails when not running as root.

Readding it in there

Closes #1608

/cc @imjasonh

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

Release Notes

Fix workingdir-init to mount the volumes when starting the initContainer.

[chmouel]

/retest

[imjasonh]

Sounds like we could use an integration test for this. I can add one after this or you can add one in this PR, up to you.

Thanks for catching this!

[chmouel]

@imjasonh good point on the integration test, but this make me wonder, do we. need the workingdir ? since it seems that nobody has realised it wasn't and nothing catastrophic has been discovered since then without it ?

[imjasonh]

Nobody may have noticed it was broken in the past few days, but most people don't run so aggressively from head either (plus, Kubecon).

If we decide to change the behavior, we should do it slowly over a couple releases with ample notice, but I don't really think we would since it's easy enough to support (when I'm not breaking it! 🤣)

/lgtm
/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ImJasonH]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

@imjasonh good point on the integration test, but this make me wonder, do we. need the workingdir ? since it seems that nobody has realised it wasn't and nothing catastrophic has been discovered since then without it ?

I think the implicit mounts are quite handy to pass content between containers.
If /workspace/ wasn't there I would end up mounting a shared folder, so it's nice to have it done by Tetkon automatically :)