Add golint to the linters #1682
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
|
/cc @bobcatfish |
|
The following is the coverage report on pkg/.
|
| @@ -45,8 +45,8 @@ type StatusKey interface { | |||
| GetRunKey() string | |||
| } | |||
|
|
|||
| // backoff contains state of exponential backoff for a given StatusKey | |||
| type backoff struct { | |||
There was a problem hiding this comment.
Was this exported because GetBackoff is exported below? Can we unexport GetBackoff instead?
There was a problem hiding this comment.
@imjasonh I should have looked 👼 let's see 😛
There was a problem hiding this comment.
We are using GetBackoff in the reconcilier 🤔
|
/test pull-tekton-pipeline-integration-tests |
pkg/credentials/gitcreds/ssh.go
Outdated
| @@ -143,7 +143,7 @@ func (be *sshEntry) Write(sshDir string) error { | |||
| return ioutil.WriteFile(be.path(sshDir), []byte(be.privateKey), 0600) | |||
| } | |||
|
|
|||
| func newSshEntry(u, secretName string) (*sshEntry, error) { | |||
| func newSSHEnrty(u, secretName string) (*sshEntry, error) { | |||
|
/lgtm |
vdemeester
force-pushed
the
linter-add-golint
branch
from
43682f9 to
1470469
Compare
|
The following is the coverage report on pkg/.
|
And update the skip-dirs list 👼 Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
linter-add-golint
branch
from
1470469 to
0d8d986
Compare
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| @@ -246,7 +246,7 @@ func getTaskRunController(t *testing.T, d test.Data) (test.TestAssets, func()) { | |||
| ctx = cloudevent.WithClient(ctx, &cloudEventClientBehaviour) | |||
| c, _ := test.SeedTestData(t, ctx, d) | |||
| configMapWatcher := configmap.NewInformedWatcher(c.Kube, system.GetNamespace()) | |||
| return test.TestAssets{ | |||
| return test.Assets{ | |||
Changes
Adds
golintto the linters, and fix the code with it 👼Related to tektoncd/plumbing#64
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.