Remove imports of golang.org/x/xerrors #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
kind/cleanup
googlebot
added
the
cla: yes
tekton-robot
added
the
size/L
|
/lgtm |
|
/hold I found some more, getting rid of them now. |
tekton-robot
added
the
do-not-merge/hold
This package was only intended to be used during the migration toward better error handling/wrapping, which is now included by default in Go 1.13. xerrors.New is now errors.New xerrors.Errorf is not fmt.Errorf Some packages imported a K8s errors package as "errors", and this change now names that import "kerrors". Some format string errors were found in migrating to fmt.Errorf, since xerrors.Errorf formatting errors weren't considered errors when running tests. Those have been fixed.
tekton-robot
added
size/XXL
|
/hold cancel The dep is now removed from Gopkg.* 🎉 |
tekton-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
/test pull-tekton-pipeline-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package was only intended to be used during the migration toward
better error handling/wrapping, which is now included by default in Go
1.13.
xerrors.Newis nowerrors.Newxerrors.Errorfis notfmt.ErrorfSome packages imported a K8s errors package as
errors, and this changenow names that import
kerrors.Some format string errors were found in migrating to
fmt.Errorf, sincexerrors.Errorfformatting errors weren't considered errors when runningtests. Those have been fixed.
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.