Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move context*.go to pkg/contexts and add tests 🎐 #1720

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Move context*.go to pkg/contexts and add tests 🎐 #1720

merged 1 commit into from
Dec 11, 2019

Conversation

vdemeester
Copy link
Member

Changes

The package it is on doesn't really matter, so adding it to the
latests api version. Also adding quick tests for this file.

This is in preparation of using it in v1alpha1 and v1alpha2. We could also move it on it's own package if the make more sense 😛

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added [in a backwards compatible way](https://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md#backwards-compa tible-changes-first).

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Dec 10, 2019
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2019
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha2/contexts.go Do not exist 100.0%

imjasonh
imjasonh reviewed Dec 10, 2019
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't matter what version it's in, does it need to be in pkg/apis/pipeline/v1alphaX at all? Can we move it to pkg/contexts or something like that?

@vdemeester
Copy link
Member Author

If it doesn't matter what version it's in, does it need to be in pkg/apis/pipeline/v1alphaX at all? Can we move it to pkg/contexts or something like that?

Yeah we can 👼, I'll update soon-ish 😝

@vdemeester vdemeester mentioned this pull request Dec 10, 2019
Merged
3 tasks
@vdemeester vdemeester force-pushed the move-context-in-v1alpha2 branch from b12d220 to 8fbfb89 Compare December 10, 2019 16:57
@vdemeester
Copy link
Member Author

@imjasonh updated 😉

@vdemeester vdemeester changed the title Move contexts to v1alpha2 and add tests 🎐 Move context*.go to pkg/contexts and add tests 🎐 Dec 10, 2019
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/contexts/contexts.go Do not exist 100.0%

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests
🙏

@vdemeester
Move context*.go to contexts and add tests 🎐
871b898 
The package it is on doesn't really matter, so adding it to the
latests api version. Also adding quick tests for this file.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the move-context-in-v1alpha2 branch from 8fbfb89 to 871b898 Compare December 11, 2019 08:16
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/contexts/contexts.go Do not exist 100.0%

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests
🤔 🙄

dibyom
dibyom approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@tekton-robot tekton-robot merged commit db33fd7 into tektoncd:master Dec 11, 2019
@vdemeester vdemeester deleted the move-context-in-v1alpha2 branch December 11, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh left review comments

@dibyom dibyom dibyom approved these changes

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vdemeester @tekton-robot @imjasonh @dibyom @googlebot