Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the release docs #1738

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Fix the release docs #1738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tekton/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The Pipelines and Tasks in this folder are used for:

To start from scratch and use these Pipelines and Tasks:

1. [Install Tekton v0.3.1](#install-tekton)
1. [Install Tekton](#install-tekton)
1. [Setup the Tasks and Pipelines](#setup)
1. [Create the required service account + secrets](#service-account-and-secrets)

Expand Down Expand Up @@ -114,7 +114,8 @@ To use [`tkn`](https://github.com/tektoncd/cli) to run the `publish-tekton-pipel

# Change the environment variable to the version you would like to use.
# Be careful: due to #983 it is possible to overwrite previous releases.
export VERSION_TAG=v0.X.Y
export VERSION_TAG=vX.Y.Z
export GIT_RESOURCE_NAME=tekton-pipelines-git-vX-Y-Z
export IMAGE_REGISTRY=gcr.io/tekton-releases

# Double-check the git revision that is going to be used for the release:
Expand All @@ -124,7 +125,7 @@ To use [`tkn`](https://github.com/tektoncd/cli) to run the `publish-tekton-pipel
--param=versionTag=${VERSION_TAG} \
--param=imageRegistry=${IMAGE_REGISTRY} \
--serviceaccount=release-right-meow \
--resource=source-repo=tekton-pipelines-git-${VERSION_TAG} \
--resource=source-repo=${GIT_RESOURCE_NAME} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, line 140 needs a \

--resource=bucket=tekton-bucket \
--resource=builtBaseImage=base-image \
--resource=builtEntrypointImage=entrypoint-image \
Expand All @@ -136,7 +137,7 @@ To use [`tkn`](https://github.com/tektoncd/cli) to run the `publish-tekton-pipel
--resource=builtDigestExporterImage=digest-exporter-image \
--resource=builtPullRequestInitImage=pull-request-init-image \
--resource=builtGcsFetcherImage=gcs-fetcher-image \
--resource=notification=post-release-trigger
--resource=notification=post-release-trigger \
pipeline-release
```

Expand Down