-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1182: Add sslVerify flag to pipelineresource type git #1752
Conversation
I noted the existing issue after I had written the code ...... I also have noted there are a number of other issues about git config parameters but thought as I has the code for this one option, I might as well open the pull request to garner interest on taking the change until other solutions might become available. |
d1e1122
to
41cf522
Compare
For reference:- #1182 was found after coding - adding link/comment here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments but overall looks great :D A couple requests:
- Are you sure that go.mod needed to change?
- Could you add release notes to your PR description describing this new feature? (e.g. https://github.com/tektoncd/pipeline/blob/master/.github/pull_request_template.md#release-notes)
Will look over dibyo's review tomorrow |
Enables the disabling in git config of http.sslVerify such that the git fetch can succeed against local gitlab installs with self signed certificates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dibbles !!
The go.mod
change still seems to be in...is that needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Yeah the go.mod
changes are… inherent… for some reason they should have been done in the go.mod
PR.. no biggies 👼
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Enables the disabling in git config of http.sslVerify such that the git fetch can succeed against local gitlab installs with self signed certificates by specifying sslVerify as "false" in the pipelineresource.
Fixes #1182
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
The
sslVerify
parameter is now available on PipelineResource's of typegit
. This property defines whether http.sslVerify should be set totrue
orfalse
in the global git config. Setting the property to false will disable certificate validation during the running of the git fetch against the git server and will be of use to people hosting git servers with self signed certificates.The parameter sslVerify defaults to
true
if omitted.Example usage: