Use vendored version of plumbing instead of go get 🦸 #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
Using `go get -d` updates continuously the plumbing dependency, without really updating the vendor folder, which will mean inconsistency. Signed-off-by: Vincent Demeester <[email protected]>
Those environment variables are not used in the rest of the script and thus consume resources (`go list …`) for nothing. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
scrtip-vendor-gomod
branch
from
97d61f8 to
218b642
Compare
|
/lgtm Thanks 👍🏼🔥 |
afrittoli
reviewed
Dec 19, 2019
| @@ -20,11 +20,6 @@ set -o pipefail | |||
|
|
|||
| source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/library.sh | |||
|
|
|||
| SCRIPT_ROOT=$(dirname "${BASH_SOURCE[0]}")/.. | |||
There was a problem hiding this comment.
I hope this one wasn't slowing us down :P
There was a problem hiding this comment.
This one wasn't, but ain't used anymore 😝
| ) | ||
|
|
||
| func TestDummy(t *testing.T) { | ||
| t.Log("This is required to make sure we get tektoncd/plumbing in the repository, folder vendor") |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
wlynch
added a commit
to wlynch/pipeline
that referenced
this pull request
Dec 26, 2019
This was something previously brought up in tektoncd#1607, but was deferred to allow for continued discussion. Pros of making this change: * Reduces size of incoming PRs when new dependencies are used. * Removes confusion around source of truth for dependencies (e.g. vendor vs mod). This was an issue that tektoncd#1763 solved by pinning to vendor, this will solve the same problem differently by always deferring to the version in go.mod. * Allows easier use of upstream and dependent types without the use of vendor - see https://gist.github.com/wlynch/325293bc3fbc488d3b3d319f3a93bbea for an example of why this is difficult today. Risks of making this change: * Dependencies will not be present in initial clone. They will be fetched dynamicly when needed, which may cause workflow distruptions. * This breaks compatibility with older versions of Go (though for certain projects like triggers, we already require Go >= 1.13). Third-party obligations (for things like making source available in images) have already been addressed in tektoncd#1607. As with tektoncd#1607, this change is more easily viewed by running `git diff master -- ':!third_party' ':!vendor'`
vdemeester
added a commit
to vdemeester/tektoncd-pipeline
that referenced
this pull request
Jan 6, 2020
Using `go get -d` updates continuously the plumbing dependency, without really updating the vendor folder, which means it becomes inconsistency. This is a follow-up of tektoncd#1763. Signed-off-by: Vincent Demeester <[email protected]>
3 tasks
vdemeester
added a commit
to vdemeester/tektoncd-pipeline
that referenced
this pull request
Jan 6, 2020
Using `go get -d` updates continuously the plumbing dependency, without really updating the vendor folder, which means it becomes inconsistency. This is a follow-up of tektoncd#1763. Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
pushed a commit
that referenced
this pull request
Jan 6, 2020
Using `go get -d` updates continuously the plumbing dependency, without really updating the vendor folder, which means it becomes inconsistency. This is a follow-up of #1763. Signed-off-by: Vincent Demeester <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
go get -dupdates continuously the plumbing dependency, without really updating the vendor folder, which will mean inconsistency.Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.