Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service port naming inline with istio naming conventions #1828

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Update service port naming inline with istio naming conventions #1828

merged 1 commit into from
Jan 16, 2020

Conversation

sravankumar777
Copy link
Contributor

https://istio.io/docs/ops/deployment/requirements/

Changes

To be on the safer side when deployed to a cluster with Istio deployed, we should follow service port naming convention as stated here -> https://istio.io/docs/setup/kubernetes/additional-setup/requirements/

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Named service ports: Service ports must be named. The port name key/value pairs must have the following syntax: name: <protocol>[-<suffix>]. See Protocol Selection for more details.
https://istio.io/docs/ops/deployment/requirements/

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2020
@tekton-robot
Copy link
Collaborator

Hi @sravankumar777. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sravankumar777
Copy link
Contributor Author

@googlebot I consent.

@sravankumar777
Copy link
Contributor Author

@googlebot I fixed it.

1 similar comment
@sravankumar777
Copy link
Contributor Author

@googlebot I fixed it.

@sravankumar777
Copy link
Contributor Author

/check-cla

@sravankumar777
Copy link
Contributor Author

@googlebot I fixed it.

@dibyom
Copy link
Member

dibyom commented Jan 10, 2020

hi @sravankumar777 looks like the CLA is associated with the Github handle. Would you mind signing it with the email address associated with the commit in this PR?

@sravankumar777
Copy link
Contributor Author

@googlebot I fixed it.

@sravankumar777
Copy link
Contributor Author

@dibyom, i tried to do the CLA procedure with email address as well.
Not sure, how to fix this again.

@sravankumar777
Copy link
Contributor Author

@googlebot I fixed it.

@dibyom
Copy link
Member

dibyom commented Jan 13, 2020 •
edited
Loading

The email associated with the commit is Is that the one you used to sign the CLA with?

@sravankumar777 sravankumar777 force-pushed the modify-service-port-naming-istio-conventions branch from fa94193 to fdaa6ca Compare January 14, 2020 00:12
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit and removed cla: no labels Jan 14, 2020
@sravankumar777
Copy link
Contributor Author

@dibyom, thanks for your support. I have resigned CLA with correct email address in new commit.

@dibyom
Copy link
Member

dibyom commented Jan 14, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2020
dibyom
dibyom reviewed Jan 14, 2020
View reviewed changes
config/400-webhook-service.yaml Outdated
@@ -21,7 +21,8 @@ metadata:
namespace: tekton-pipelines
spec:
ports:
- port: 443
- name: http-webhook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be https? https://istio.io/docs/ops/configuration/traffic-management/protocol-selection/#manual-protocol-selection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dibyom, new commit added for change of http-webhook to https-webhook.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sravankumar777 sravankumar777 requested a review from dibyom January 15, 2020 00:51
dibyom
dibyom reviewed Jan 15, 2020
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind squashing the two commits into one? LGTM otherwise!

@sravankumar777 sravankumar777 force-pushed the modify-service-port-naming-istio-conventions branch from 13798f0 to 0e5bb97 Compare January 16, 2020 06:03
@sravankumar777
Copy link
Contributor Author

Would you mind squashing the two commits into one? LGTM otherwise!

Thanks for your comments.
I did squash the commits, please check it.

@sravankumar777 sravankumar777 requested a review from dibyom January 16, 2020 06:29
vdemeester
vdemeester approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@chmouel
Copy link
Member

chmouel commented Jan 16, 2020

/lgtm

Looking Good! 🤙🏽 I would love to see a use case on how istio and tekton are used on the control plane..

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@tekton-robot tekton-robot merged commit 23a9554 into tektoncd:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@imjasonh imjasonh Awaiting requested review from imjasonh

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@chmouel chmouel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sravankumar777 @googlebot @tekton-robot @dibyom @chmouel @vdemeester