Update go.mod comment with the correct k8s version 😈

[vdemeester]

Changes

This is one of the downside of go modules, it replace the branch name
to a git magic thingy, making it impossible to know which branch you
were tracking initially.

The comment was saying 1.12.9, but it is 1.13.4 (k8s deps got bump
before switching to go modules and the comment was never updated).

Signed-off-by: Vincent Demeester [email protected]

/cc @wlynch @bobcatfish @a-roberts

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

[a-roberts]

Yeah definitely looks to be 1.13, so we see https://github.com/kubernetes/apimachinery/commits/01f8b7d1121a gets mentioned and that went into 1.13, this must have been pretty tedious to figure out (could we do something better to make it easier in future?!)

Otherwise lgtm 😸

[vdemeester]

Yeah definitely looks to be 1.13, so we see https://github.com/kubernetes/apimachinery/commits/01f8b7d1121a gets mentioned and that went into 1.13, this must have been pretty tedious to figure out (could we do something better to make it easier in future?!)

Actually, I didn't really try to figure it out… I look at the git history to see the latest k8s bump. But on "updating" the k8s dependencies in go modules, the way to go would be to update the replace part of the go.mod with the branch name:

replace (
	k8s.io/api => k8s.io/api kubernetes-1.13.4
	k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver kubernetes-1.13.4
	k8s.io/apimachinery => k8s.io/apimachinery kubernetes-1.13.4
	// [ …] for the rest too…
)

and then run go build -v ./... && go mod tidy && go mod vendor... go will replace those branch name with the git magic thingy… and this is something I really dislike but…

[chmouel]

/lgtm
/approve

Thanks 👍🏼🔥

[afrittoli]

Nice, thank you!
/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afrittoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment