Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all alpine packages are updated to their latest versions. #1835

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

othomann
Copy link
Contributor

@othomann othomann commented Jan 9, 2020

Changes

Make sure all alpine packages are updated to their latest versions.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Future releases won't include vulnerabilities fixed in the alpine packages but not yet built into the alpine:latest docker image.

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 9, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2020
@tekton-robot
Copy link
Collaborator

Hi @othomann. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@othomann thanks for the PR, can you update the commit message to add the description instead of the message Fix … ?

Make sure all alpine packages are updated to their latest versions.

The git commit title and description should contains what the commit does, not which issue number it fixes (in case we would use something else that GitHub in the future, or…)

@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2020
@bobcatfish
Copy link
Collaborator

To expand on @vdemeester 's request, a few more things:

  • Usually the title of the PullRequest will describe the change, e.g. in this case maybe "Make sure all alpine packages are updated to their latest versions."
  • These are the commit message guidelines, as he mentioned the commit message should be descriptive: https://github.com/tektoncd/community/blob/master/standards.md#commit-messages
  • The "release notes" section is intended for you to fill in with anything that is relevant in future releases - in this case you might say something about how future releases won't include such and such vulnerabilities

@othomann othomann changed the title Fix for https://github.com/tektoncd/pipeline/issues/1833 Make sure all alpine packages are updated to their latest versions. Jan 9, 2020
@othomann othomann requested a review from vdemeester January 9, 2020 17:27
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@othomann
Copy link
Contributor Author

othomann commented Jan 9, 2020

/retest

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@othomann
Copy link
Contributor Author

othomann commented Jan 9, 2020

@vdemeester I added a new line at the end of the Dockerfile. I cannot explain why the integration tests are failing with only this change.

@vdemeester
Copy link
Member

@othomann might be flakyness 😓

@othomann
Copy link
Contributor Author

othomann commented Jan 9, 2020

the lgtm flag has been removed because of my latest change (addition of an empty line at the end of the Dockerfile).

@othomann
Copy link
Contributor Author

othomann commented Jan 9, 2020

@vdemeester all tests are green now.

@chmouel
Copy link
Member

chmouel commented Jan 9, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@othomann
Copy link
Contributor Author

othomann commented Jan 9, 2020

Not sure why the pipeline build tests now reports:

I0109 19:19:45.108] ===============================
I0109 19:20:32.325] pkg/client/resource/informers/externalversions/generic.go:54:2: singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
I0109 19:20:32.326] 	switch resource {
I0109 19:20:32.326] 	^
I0109 19:20:32.429] ============================

@othomann
Copy link
Contributor Author

othomann commented Jan 9, 2020

/test pull-tekton-pipeline-build-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants