-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure all alpine packages are updated to their latest versions. #1835
Conversation
Hi @othomann. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@othomann thanks for the PR, can you update the commit message to add the description instead of the message Fix …
?
Make sure all alpine packages are updated to their latest versions.
The git commit title and description should contains what the commit does, not which issue number it fixes (in case we would use something else that GitHub in the future, or…)
/ok-to-test |
To expand on @vdemeester 's request, a few more things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@vdemeester I added a new line at the end of the Dockerfile. I cannot explain why the integration tests are failing with only this change. |
@othomann might be flakyness 😓 |
the lgtm flag has been removed because of my latest change (addition of an empty line at the end of the Dockerfile). |
@vdemeester all tests are green now. |
/lgtm |
Not sure why the pipeline build tests now reports:
|
/test pull-tekton-pipeline-build-tests |
Changes
Make sure all alpine packages are updated to their latest versions.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes