Add Condition to v1alpha2 🎋

[vdemeester]

Changes

This port Condition from v1alpha1 as is to v1alpha2.

This depends on #1841 and #1725 (as it is based on those two)

/hold
/cc @bobcatfish

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha2/condition_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha2/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha2/condition_validation.go	Do not exist	87.5%
pkg/apis/pipeline/v1alpha2/task_validation.go	74.8%	83.8%	9.0
pkg/apis/pipeline/v1alpha2/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/taskrun_types.go	Do not exist	74.1%
pkg/apis/pipeline/v1alpha2/taskrun_validation.go	Do not exist	96.2%
pkg/apis/pipeline/v1alpha2/workspace_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha2/workspace_validation.go	Do not exist	100.0%

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha2/condition_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha2/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha2/condition_validation.go	Do not exist	87.5%

[vdemeester]

/hold cancel

[ghost]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha2/condition_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha2/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1alpha2/condition_validation.go	Do not exist	87.5%

[bobcatfish]

mentioned this is slack also but I'd rather hold off on making Condition part of beta since a) it's pretty new b) i'm not sure we've actually completed the epic yet (@dibyom correct me if I'm wrong) and c) in my own experience I haven't been able to use it the way I've wanted to (that's just me tho - and I think @dlorenc has had similar experiences). so personally I'd rather give it a bit of a revisit first

[vdemeester]

/hold

[dibyom]

I think the missing features are mostly going to be in the PipelineTask side rather than in the Condition CRD (e.g. chaining conditions, or #1684). That being said, I'm for waiting on making Conditions Beta (do we even need a extra CRD...can we just reuse some "kinds" of tasks/steps instead?)

[vdemeester]

I guess I can close this for now 👼
/close

[tekton-robot]

@vdemeester: Closed this PR.

In response to this:

I guess I can close this for now 👼
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.