Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some test to be closer to golang naming convention 💅 #1850

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

vdemeester
Copy link
Member

Changes

Usually it is TestF() and TestF_Case() for a function F().

This is completely nits but… I don't like seeing Test_Foo_Bar() when looking at tests 😅.

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Usually it is `TestF()` and `TestF_Case()` for a function `F()`.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot requested review from abayer and a user January 10, 2020 14:34
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 10, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2020
@ghost
Copy link

ghost commented Jan 10, 2020

I don't like seeing Test_Foo_Bar() when looking at tests 😅.

💯👮

/lgtm
/test tekton-pipeline-unit-tests

@tekton-robot tekton-robot assigned ghost Jan 10, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2020
@ghost
Copy link

ghost commented Jan 10, 2020

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@tekton-robot tekton-robot merged commit 36b4aaa into tektoncd:master Jan 10, 2020
@vdemeester vdemeester deleted the test-name-convention branch January 10, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants