Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate and sort termination message items #1851

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

imjasonh
Copy link
Member

If a user or resource writes to /tekton/termination to append an output
result, later ones should win.

Also sort the deduplicated results for reproducibility.

cc @othomann

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

If a user or resource writes to /tekton/termination to append an output
result, later ones should win.

Also sort the deduplicated results for reproducibility.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 10, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2020
@imjasonh
Copy link
Member Author

/retest

@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-build-tests

I0110 16:14:02.624] go get github.com/google/go-licenses: module github.com/google/go-licenses: Get https://proxy.golang.org/github.com/google/go-licenses/@v/list: net/http: TLS handshake timeout
I0110 16:14:02.670] /go/src/github.com/tektoncd/pipeline/vendor/github.com/tektoncd/plumbing/scripts/library.sh: line 325: go-licenses: command not found

@ghost
Copy link

ghost commented Jan 10, 2020

/lgtm
/approve

@tekton-robot tekton-robot assigned ghost Jan 10, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@imjasonh
Copy link
Member Author

I0110 19:44:30.497] go get github.com/google/go-licenses: module github.com/google/go-licenses: Get https://proxy.golang.org/github.com/google/go-licenses/@v/list: net/http: TLS handshake timeout
I0110 19:44:30.499] /go/src/github.com/tektoncd/pipeline/vendor/github.com/tektoncd/plumbing/scripts/library.sh: line 325: go-licenses: command not found

/test pull-tekton-pipeline-build-tests

@imjasonh
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit 3ae789c into tektoncd:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants