-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(dev): never use "here" as a link #1892
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @docwhat. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @docwhat ! Looks like you need to sign the CLA before we can merge 🙏
Side note: @spomorski is working on a style guide for us so we can stop doing stuff like this :D
@@ -19,7 +19,7 @@ on path `/pvc` by PipelineRun. | |||
Another alternatives is to use a GCS storage or S3 bucket to share the artifacts. | |||
This can be configured using a ConfigMap with the name `config-artifact-bucket`. | |||
|
|||
See [here](../install.md#how-are-resources-shared-between-tasks) for configuration details. | |||
See the [installation docs](../install.md#how-are-resources-shared-between-tasks) for configuration details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooo much clearer!
Great idea - just added this to our style guide. :)
…On Fri, Jan 17, 2020 at 2:13 PM Christie Wilson ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for this @docwhat <https://github.com/docwhat> ! Looks like you
need to sign the CLA before we can merge 🙏
Side note: @spomorski <https://github.com/spomorski> is working on a
style guide for us so we can stop doing stuff like this :D
------------------------------
In docs/developers/README.md
<#1892 (comment)>:
> @@ -19,7 +19,7 @@ on path `/pvc` by PipelineRun.
Another alternatives is to use a GCS storage or S3 bucket to share the artifacts.
This can be configured using a ConfigMap with the name `config-artifact-bucket`.
-See [here](../install.md#how-are-resources-shared-between-tasks) for configuration details.
+See the [installation docs](../install.md#how-are-resources-shared-between-tasks) for configuration details.
oooo much clearer!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1892?email_source=notifications&email_token=AG3UR4RQ2WSRFLG2HVUQF4TQ6H7NVA5CNFSM4KIJ6N62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSGQEKY#pullrequestreview-344785451>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG3UR4S5ZF6SYBAQH3LEHR3Q6H7NVANCNFSM4KIJ6N6Q>
.
|
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tiny change because you should never use "here" as a link.