-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for default pod template #1901
Conversation
Hi @eddycharly. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The following is the coverage report on pkg/.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test tekton-pipeline-unit-tests |
The following is the coverage report on pkg/.
|
fix task test
The following is the coverage report on pkg/.
|
/lgtm |
This PR adds support for a default pod template through the default ConfigMap.
This is useful when one wants to apply a pod template to all task and pipeline runs, for example specifying a node selector, a security policy, etc...
When a pod template is specified for a PipelineRun or TaskRun it takes precedence over the default pod template.
Therefore, the default pod template only applies to PipelineRun or TaskRun that don't have a pod template.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: