Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pipelinerun as "cancelled" when taskrun is "cancelled" #1935

Merged

Conversation

vincent-pli
Copy link
Member

@vincent-pli vincent-pli commented Jan 24, 2020

Fix issue: #1900

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Make pipelinerun as "cancelled" when taskrun is "cancelled"

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 24, 2020
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2020
@tekton-robot tekton-robot requested review from abayer and a user January 24, 2020 10:59
@vincent-pli vincent-pli force-pushed the correct-state-pipelinerun-cancelled branch from 55971b1 to e665cd6 Compare January 24, 2020 13:21
@vincent-pli vincent-pli requested a review from a user January 24, 2020 13:30
@ghost
Copy link

ghost commented Jan 24, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Jan 24, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(added something in the release not part of the PR)

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
@tekton-robot tekton-robot merged commit 84368ae into tektoncd:master Jan 24, 2020
@vincent-pli vincent-pli deleted the correct-state-pipelinerun-cancelled branch January 25, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants