Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterTask to v1alpha2 🎋 #1946

Merged
merged 2 commits into from
Jan 27, 2020

Conversation

vdemeester
Copy link
Member

Changes

This port ClusterTask spec to v1alpha2, using v1alpha2.TaskSpec too.

/cc @sbwsg @bobcatfish

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

This was missed when adding `TaskRun` to `v1alpha2` 😓

Signed-off-by: Vincent Demeester <[email protected]>
This port ClusterTask spec to v1alpha2, using v1alpha2.TaskSpec too.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot requested review from bobcatfish and a user January 27, 2020 14:33
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 27, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 27, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha2/cluster_task_defaults.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha2/cluster_task_types.go Do not exist 0.0%
pkg/apis/pipeline/v1alpha2/cluster_task_validation.go Do not exist 0.0%

@ghost
Copy link

ghost commented Jan 27, 2020

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@chmouel
Copy link
Member

chmouel commented Jan 27, 2020

/lgtm

Looking Good! 🤙🏽

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2020
@tekton-robot tekton-robot merged commit 3d6f1d3 into tektoncd:master Jan 27, 2020
@vdemeester vdemeester deleted the v1alpha2-clustertask branch January 27, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants