Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the number of expected pods created in e2e test case of "retry" #1996

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

vincent-pli
Copy link
Member

@vincent-pli vincent-pli commented Feb 4, 2020

Changes

Fix the test case mentioned in #1976
This PR only fix the test case not the bug mentioned in the issue, that bug need further research.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Feb 4, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2020
@vincent-pli
Copy link
Member Author

/assign @imjasonh

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little bit confused - does this PR fix the issue or just modify the test case to more accurately reflect the problem? (iow does the bug still exist or not?)

Could you update the commit message and PR description to describe what's being achieved? I'm unclear if we're fixing the bug or just some of the test details.

test/retry_test.go Outdated Show resolved Hide resolved
@vincent-pli vincent-pli requested a review from a user February 4, 2020 14:23
test/retry_test.go Outdated Show resolved Hide resolved
@vincent-pli vincent-pli force-pushed the correct-retry-test-case branch from 446606e to ed84811 Compare February 4, 2020 23:42
@ghost
Copy link

ghost commented Feb 5, 2020

Just pulling a previous comment out of the resolved review comment:

Ah I totally understand, thanks @vincent-pli ! Could you update the commit message as well to reflect this? Something like Correct the number of expected pods created during retries e2e test

@vincent-pli vincent-pli changed the title Correct testcase of "retry" Correct the number of expected pods created in e2e test case of "retry" Feb 5, 2020
@vincent-pli
Copy link
Member Author

@sbwsg
Done, thanks.

@ghost
Copy link

ghost commented Feb 5, 2020

Sorry for the confusion - I meant the commit message, modified by git commit --amend. This is so that the git log history shows the updated information. Thanks and sorry again for the confusion!

@vincent-pli vincent-pli force-pushed the correct-retry-test-case branch from ed84811 to 2ca7cd2 Compare February 5, 2020 14:39
@vincent-pli
Copy link
Member Author

/retest

@ghost
Copy link

ghost commented Feb 5, 2020

🙏 thank you!

/lgtm

@tekton-robot tekton-robot assigned ghost Feb 5, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@dibyom
Copy link
Member

dibyom commented Feb 5, 2020

Looks like you need to run goimports. LGTM otherwise

I0205 15:43:39.146] ==== RUNNING GOLANGCI-LINT ====
I0205 15:43:39.146] ===============================
I0205 15:47:00.972] cmd/creds-init/main.go:19: File is not goimports-ed (goimports)
I0205 15:47:00.992] "flag"
I0205 15:47:00.995] pkg/entrypoint/entrypointer.go:21: File is not goimports-ed (goimports)
I0205 15:47:00.996] "go.uber.org/zap"
I0205 15:47:00.996] cmd/git-init/main.go:19: File is not goimports-ed (goimports)
I0205 15:47:00.996] "flag"

@dibyom
Copy link
Member

dibyom commented Feb 5, 2020

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@vdemeester
Copy link
Member

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot merged commit b024853 into tektoncd:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants