-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the number of expected pods created in e2e test case of "retry" #1996
Correct the number of expected pods created in e2e test case of "retry" #1996
Conversation
/assign @imjasonh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little bit confused - does this PR fix the issue or just modify the test case to more accurately reflect the problem? (iow does the bug still exist or not?)
Could you update the commit message and PR description to describe what's being achieved? I'm unclear if we're fixing the bug or just some of the test details.
446606e
to
ed84811
Compare
Just pulling a previous comment out of the resolved review comment: Ah I totally understand, thanks @vincent-pli ! Could you update the commit message as well to reflect this? Something like Correct the number of expected pods created during retries e2e test |
@sbwsg |
Sorry for the confusion - I meant the commit message, modified by |
ed84811
to
2ca7cd2
Compare
/retest |
🙏 thank you! /lgtm |
Looks like you need to run goimports. LGTM otherwise
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-pipeline-build-tests |
Changes
Fix the test case mentioned in #1976
This PR only fix the test case not the bug mentioned in the issue, that bug need further research.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes