Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LimitRange Examples for PipelineRun and TaskRun #2004

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

danielhelfand
Copy link
Member

Adding some examples to illustrate #1991 for specifying a LimitRangeName as part of pipelineruns/taskruns.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

Add examples for specifying a LimitRangeName as part of a pipelinerun/taskrun

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Feb 5, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2020
@danielhelfand
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@ghost
Copy link

ghost commented Feb 5, 2020

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@danielhelfand
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@danielhelfand
Copy link
Member Author

Unfortunately, the examples here create a LimitRange which causes all other examples to fail since they don't take into account limitRangeName. Moving the examples to no-ci and will make them more visible by including in documentation.

@ghost
Copy link

ghost commented Feb 6, 2020

oh cool, i didn't know no-ci existed!

Would be great to get these limitranges running on every push at some point though. I'll create an issue on plumbing to address this - maybe we need to run each example in its own namespace?

/lgtm

@tekton-robot tekton-robot assigned ghost Feb 6, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@danielhelfand
Copy link
Member Author

  • maybe we need to run each example in its own namespace?

Yeah, if these examples are excluded from the others in a different namespace, they would work. But would be great if we could create different namespaces for certain examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants