-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LimitRange Examples for PipelineRun and TaskRun #2004
Add LimitRange Examples for PipelineRun and TaskRun #2004
Conversation
/test pull-tekton-pipeline-integration-tests |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-pipeline-integration-tests |
05c6815
to
4096319
Compare
Unfortunately, the examples here create a LimitRange which causes all other examples to fail since they don't take into account |
oh cool, i didn't know Would be great to get these limitranges running on every push at some point though. I'll create an issue on plumbing to address this - maybe we need to run each example in its own namespace? /lgtm |
Yeah, if these examples are excluded from the others in a different namespace, they would work. But would be great if we could create different namespaces for certain examples. |
Adding some examples to illustrate #1991 for specifying a LimitRangeName as part of pipelineruns/taskruns.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes