Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to include Tekton installtion #2012

Merged
merged 3 commits into from
Feb 7, 2020

Conversation

dewan-ahmed
Copy link
Contributor

@dewan-ahmed dewan-ahmed commented Feb 6, 2020

Without this, students trying this tutorial will get:
error: unable to recognize "task.yaml": no matches for kind "Task" in version "tekton.dev/v1alpha1"

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

Without this, students trying this tutorial will get:
error: unable to recognize "task.yaml": no matches for kind "Task" in version "tekton.dev/v1alpha1"
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2020
@tekton-robot
Copy link
Collaborator

Hi @dewan-ahmed. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dewan-ahmed
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit and removed cla: no labels Feb 6, 2020
@dewan-ahmed
Copy link
Contributor Author

HI @vdemeester @dlorenc pls let me know if any action item pending from me. Thanks

@ghost
Copy link

ghost commented Feb 6, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2020
docs/tutorial.md Outdated
@@ -9,7 +9,11 @@ This tutorial will walk you through creating and running some simple
- [Creating a hello world `Task`](#task)
- [Creating a hello world `Pipeline`](#pipeline)

Before starting this tutorial, please install the [Tekton CLI](https://github.com/tektoncd/cli).
Before starting this tutorial, please install the [Tekton CLI](https://github.com/tektoncd/cli) and install the latest Tekton release by the following command:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hard-coding the kubectl command here, how about linking to the install doc we have for tekton at ./install.md? The user might need to go through the steps of setting up a cluster as well before starting the tutorial and that would be covered by linking to the existing install doc.

@dewan-ahmed
Copy link
Contributor Author

dewan-ahmed commented Feb 6, 2020 via email

@ghost
Copy link

ghost commented Feb 7, 2020

Is your recommendation more on adding a link to https://github.com/tektoncd/pipeline/blob/master/docs/install.md#installing-tekton-pipelines rather than hardcoding the kubectl command?

Yeah that would be great, thank you!

@dewan-ahmed
Copy link
Contributor Author

@sbwsg Is there an action item on me for tide Pending — Not mergeable. Needs approved, lgtm labels. ?

@ghost
Copy link

ghost commented Feb 7, 2020

Please update your PR to include the link instead of hard-coding the kubectl command. Once that is done I will approve and lgtm and the PR will be merged. Many thanks!

@ghost
Copy link

ghost commented Feb 7, 2020

/lgtm
/approve

@tekton-robot tekton-robot assigned ghost Feb 7, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2020
@tekton-robot tekton-robot merged commit 21de79a into tektoncd:master Feb 7, 2020
@dewan-ahmed dewan-ahmed deleted the patch-1 branch February 7, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants