-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to include Tekton installtion #2012
Conversation
Without this, students trying this tutorial will get: error: unable to recognize "task.yaml": no matches for kind "Task" in version "tekton.dev/v1alpha1"
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @dewan-ahmed. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
HI @vdemeester @dlorenc pls let me know if any action item pending from me. Thanks |
/ok-to-test |
docs/tutorial.md
Outdated
@@ -9,7 +9,11 @@ This tutorial will walk you through creating and running some simple | |||
- [Creating a hello world `Task`](#task) | |||
- [Creating a hello world `Pipeline`](#pipeline) | |||
|
|||
Before starting this tutorial, please install the [Tekton CLI](https://github.com/tektoncd/cli). | |||
Before starting this tutorial, please install the [Tekton CLI](https://github.com/tektoncd/cli) and install the latest Tekton release by the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of hard-coding the kubectl command here, how about linking to the install doc we have for tekton at ./install.md? The user might need to go through the steps of setting up a cluster as well before starting the tutorial and that would be covered by linking to the existing install doc.
Absolutely! The Hello World Tutorial can be seen as a stand-alone guide from a student perspective and this guide does not contain the step on installing Tekton. Is your recommendation more on adding a link to https://github.com/tektoncd/pipeline/blob/master/docs/install.md#installing-tekton-pipelines rather than hardcoding the kubectl command?
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Scott <[email protected]>
Sent: Thursday, February 6, 2020 3:26:34 PM
To: tektoncd/pipeline <[email protected]>
Cc: Dewan Ahmed <[email protected]>; Mention <[email protected]>
Subject: Re: [tektoncd/pipeline] Updating to include Tekton installtion (#2012)
@sbwsg commented on this pull request.
________________________________
In docs/tutorial.md<#2012 (comment)>:
@@ -9,7 +9,11 @@ This tutorial will walk you through creating and running some simple
- [Creating a hello world `Task`](#task)
- [Creating a hello world `Pipeline`](#pipeline)
…-Before starting this tutorial, please install the [Tekton CLI](https://github.com/tektoncd/cli).
+Before starting this tutorial, please install the [Tekton CLI](https://github.com/tektoncd/cli) and install the latest Tekton release by the following command:
Instead of hard-coding the kubectl command here, how about linking to the install doc we have for tekton at ./install.md? The user might need to go through the steps of setting up a cluster as well before starting the tutorial and that would be covered by linking to the existing install doc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2012?email_source=notifications&email_token=AHJPZLPKCNCPADQRRTGKVVLRBRW7VA5CNFSM4KRBSCYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUSQNNA#pullrequestreview-354748084>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJPZLLVLDOW5IRSCGII5QDRBRW7VANCNFSM4KRBSCYA>.
|
Yeah that would be great, thank you! |
@sbwsg Is there an action item on me for tide Pending — Not mergeable. Needs approved, lgtm labels. ? |
Please update your PR to include the link instead of hard-coding the kubectl command. Once that is done I will approve and lgtm and the PR will be merged. Many thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Without this, students trying this tutorial will get:
error: unable to recognize "task.yaml": no matches for kind "Task" in version "tekton.dev/v1alpha1"
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes