Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink in kodata 🔗 #2032

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Feb 11, 2020

Changes

This allows ko to be less noisy. This replicates what knative does
in serving and elsewhere.

Not sure if we wanna go through with it or not but here it is.
Related to #2028

Signed-off-by: Vincent Demeester [email protected]

/cc @steveodonovan @imjasonh @afrittoli @mattmoor

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

This allows `ko` to be less noisy. This replicates what knative does
in serving and elsewhere.

Signed-off-by: Vincent Demeester <[email protected]>
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Feb 11, 2020
@tekton-robot
Copy link
Collaborator

@vdemeester: GitHub didn't allow me to request PR reviews from the following users: mattmoor.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

This allows ko to be less noisy. This replicates what knative does
in serving and elsewhere.

Not sure if we wanna go through with it or not but here it is.
Related to #2028

Signed-off-by: Vincent Demeester [email protected]

/cc @steveodonovan @imjasonh @afrittoli @mattmoor

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 11, 2020
@chmouel
Copy link
Member

chmouel commented Feb 11, 2020

/lgtm

That supposed to go in the image, right ?

(we build our own image with ko)

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@vdemeester
Copy link
Member Author

@chmouel yeah 😅

@mattmoor
Copy link
Member

/lgtm

@tekton-robot
Copy link
Collaborator

@mattmoor: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abayer
Copy link
Contributor

abayer commented Feb 13, 2020

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2020
@chmouel
Copy link
Member

chmouel commented Feb 13, 2020

/lgtm

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-build-tests

1 similar comment
@dibyom
Copy link
Member

dibyom commented Feb 13, 2020

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot merged commit d56cb94 into tektoncd:master Feb 13, 2020
@vdemeester vdemeester deleted the update-kodata branch February 13, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants