Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the installation guide for clarity and flow. #2104

Closed
wants to merge 8 commits into from
Closed

Rewrite the installation guide for clarity and flow. #2104

wants to merge 8 commits into from

Conversation

tualeron
Copy link
Contributor

Rewrites the Tekton Pipelines installation guide for better clarity and flow.

Rewrites the Tekton Pipelines installation guide for better clarity and flow.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Feb 25, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2020
@vdemeester
Copy link
Member

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 26, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits but otherwise this lgtm to me!

docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
Fixes typos and applies the correct verb to "ConfigMap."
@tualeron
Copy link
Contributor Author

tualeron commented Feb 26, 2020 via email

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you!
You may need a rebase though.
See also #2123 - it would be good to integrate with it - either of the two will need a rebase

docs/install.md Show resolved Hide resolved
docs/install.md Show resolved Hide resolved
@tualeron
Copy link
Contributor Author

Nice thank you!
You may need a rebase though.
See also #2123 - it would be good to integrate with it - either of the two will need a rebase

Since my rewrite is a lot more extensive, it's better to integrate your addition into my PR.

Addresses comments from afrittoli@.
Adds the GoogleCloudStorage example config and other changes from PR 2123.
docs/install.md Outdated

* **[Official](https://github.com/tektoncd/pipeline/releases)** - install this unless you have
a specific reason to go for a different release.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newline?

I AM SO SORRY

Fixes formatting.
@bobcatfish
Copy link
Collaborator

/hold

for commit squash :D

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@tualeron tualeron closed this Mar 3, 2020
tekton-robot pushed a commit that referenced this pull request Mar 3, 2020
Rewrites the Tekton Pipelines Installation Guide for improved clarity, organization, and flow.

This is a commit-squashed version of #2104.
@tualeron tualeron deleted the patch-5 branch March 3, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants