-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the installation guide for clarity and flow. #2104
Conversation
Rewrites the Tekton Pipelines installation guide for better clarity and flow.
/kind documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits but otherwise this lgtm to me!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes typos and applies the correct verb to "ConfigMap."
/retest
…On Wed, Feb 26, 2020 at 4:41 PM tekton-robot ***@***.***> wrote:
@spomorski <https://github.com/spomorski>: The following tests *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
pull-tekton-pipeline-go-coverage e99818d
<e99818d>
link
<https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_pipeline/2104/pull-tekton-pipeline-go-coverage/1232782578843389952/> /test
pull-tekton-pipeline-go-coverage
pull-tekton-pipeline-build-tests e99818d
<e99818d>
link
<https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_pipeline/2104/pull-tekton-pipeline-build-tests/1232782578843389953/> /test
pull-tekton-pipeline-build-tests
pull-tekton-pipeline-unit-tests e99818d
<e99818d>
link
<https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_pipeline/2104/pull-tekton-pipeline-unit-tests/1232782578843389954/> /test
tekton-pipeline-unit-tests
pull-tekton-pipeline-integration-tests e99818d
<e99818d>
link
<https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_pipeline/2104/pull-tekton-pipeline-integration-tests/1232782578843389955/> /test
pull-tekton-pipeline-integration-tests
Full PR test history
<https://tekton-releases.appspot.com/pr/tektoncd_pipeline/2104>. Your PR
dashboard <https://prow.tekton.dev/pr/spomorski>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2104?email_source=notifications&email_token=AG3UR4TXSYKEBUMHP2JGSWLRE3O2BA5CNFSM4K3PWPJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENB77IQ#issuecomment-591658914>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG3UR4XRPYO67QTJDM24GLTRE3O2BANCNFSM4K3PWPJA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thank you!
You may need a rebase though.
See also #2123 - it would be good to integrate with it - either of the two will need a rebase
Since my rewrite is a lot more extensive, it's better to integrate your addition into my PR. |
Addresses comments from afrittoli@.
Adds the GoogleCloudStorage example config and other changes from PR 2123.
docs/install.md
Outdated
|
||
* **[Official](https://github.com/tektoncd/pipeline/releases)** - install this unless you have | ||
a specific reason to go for a different release. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra newline?
I AM SO SORRY
Fixes formatting.
/hold for commit squash :D |
Rewrites the Tekton Pipelines Installation Guide for improved clarity, organization, and flow. This is a commit-squashed version of #2104.
Rewrites the Tekton Pipelines installation guide for better clarity and flow.