refactor pipeline validation #2504
Conversation
tekton-robot
added
the
size/L
pritidesai
force-pushed
the
refactor-validation
branch
from
dff0bb1 to
fd32d41
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
pritidesai
force-pushed
the
refactor-validation
branch
from
fd32d41 to
7ee54ae
Compare
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-integration-tests |
|
/test pull-tekton-pipeline-build-tests |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-integration-tests |
|
Is there anything worth mentioning in the Release Notes section of the PR? If not, please remove it. |
|
/test pull-tekton-pipeline-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-integration-tests |
|
/retest |
|
/lgtm cancel |
|
/test pull-tekton-pipeline-integration-tests |
|
/test pull-tekton-pipeline-build-tests |
|
/lgtm |
This change is part of the larger effort to add pipeline level finally. This initial refactoring is done so that it simplifies implementing validation for finally section which is similar to tasks section. This refactoring includes: 1) creating a new local function validatePipelineTasks which contians check on PipelineTask name and validates PipelineTask to at least contian one of taskRef or taskSpec. The same function will then be used by finally section as well. 2) Changing return type of validateFrom
pritidesai
force-pushed
the
refactor-validation
branch
from
7ee54ae to
f0ff9d9
Compare
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-build-tests |
|
/lgtm |
|
@bobcatfish, starting to refactor pipeline validation like you mentioned here, more refactoring is on the way ✍️ |
|
/test pull-tekton-pipeline-build-tests |
Changes
This change is part of the larger effort to add pipeline level finally.
This initial refactoring is done so that it simplifies implementing
validation for finally section which is similar to tasks section.
This refactoring includes:
check on PipelineTask name and validates PipelineTask to at least contain
one of taskRef or taskSpec. The same function will then be used by finally
section as well.
This refactoring simplifies changes listed in finally PR: #2437
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.