Add validation for condition check name #2528
Conversation
tekton-robot
added
the
size/S
piyush-garg
force-pushed
the
fix_cond_validation
branch
from
5fcf3e6 to
e73b994
Compare
|
The following is the coverage report on the affected files.
|
This will add validation for condition check name like the one we are doing for task step name Right now the condition is getting created with invalid name format but when we use it in pipeline its not working
piyush-garg
force-pushed
the
fix_cond_validation
branch
from
e73b994 to
7564632
Compare
|
The following is the coverage report on the affected files.
|
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
|
/lgtm |
|
/test pull-tekton-pipeline-integration-tests |
2 similar comments
|
/test pull-tekton-pipeline-integration-tests |
|
/test pull-tekton-pipeline-integration-tests |
This will add validation for condition check name like the
one we are doing for task step name
Right now the condition is getting created with
invalid name format but when we use it in pipeline
its not working
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes