Git PipelineResource errs when HOME != /tekton/home & UID is non-zero #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
ah needs a rebase 🙏 |
When the disable-home-env-overwrite flag is "true"... Currently the git pipelineresource errors out if a securityContext is set on a TaskRun. This happens because it will attempt to lock $HOME/.gitconfig. If UID is non-zero and HOME is not set then it tries to lock `//.gitconfig` which is in a root-owned directory. This commit sets an explicit home directory of /tekton/home for the git pipelineresource. This volume mount always exists, even if the user has set the disable-home-env-overwrite flag to "true", and it's always world-writeable since it's an emptyDir with no permissions set on it.
|
Cheers, rebased! |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2523
Changes
When the disable-home-env-overwrite flag is "true"...
Currently the git pipelineresource errors out if a securityContext
is set on a TaskRun. This happens because it will attempt to lock
$HOME/.gitconfig. If UID is non-zero and HOME is not set then it
tries to lock
//.gitconfigwhich is in a root-owned directory.This commit sets an explicit home directory of /tekton/home for the git
pipelineresource. This volume mount always exists, even if the user
has set the disable-home-env-overwrite flag to "true", and it's always
world-writeable since it's an emptyDir with no permissions set on it.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: