Use the condition name in tekton.dev/conditionCheck #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XS
afrittoli
force-pushed
the
issues/2578-condition-check-label
branch
from
8909330 to
c36caa7
Compare
tekton-robot
added
size/S
|
/kind bug |
The condition is implemented with a TaskRun. Right now the TaskRun is labelled with tekton.dev/conditionCheck which contains the name of the TaskRun itself. We should instead use the label to carry data that is useful for discovering this TaskRun, and which is not already available, i.e. the name of the Condition from which the TaskRun was generated.
afrittoli
force-pushed
the
issues/2578-condition-check-label
branch
from
c36caa7 to
106ad1e
Compare
|
The following is the coverage report on the affected files.
|
dibyom
approved these changes
May 7, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The condition is implemented with a TaskRun. Right now the TaskRun
is labelled with tekton.dev/conditionCheck which contains the
name of the TaskRun itself. We should instead use the label to
carry data that is useful for discovering this TaskRun, and which
is not already available, i.e. the name of the Condition from
which the TaskRun was generated.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes