Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PipelineResources link #2585

Merged
merged 1 commit into from
May 8, 2020
Merged

Fix PipelineResources link #2585

merged 1 commit into from
May 8, 2020

Conversation

plumpy
Copy link
Contributor

@plumpy plumpy commented May 8, 2020

The stray backtick prevented the link from rendering.

@linux-foundation-easycla
Copy link

CLA Check

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2020
@tekton-robot
Copy link
Collaborator

Hi @plumpy. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/kind documentation
/ok-to-test

@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2020
@afrittoli
Copy link
Member

Thank you for the fix and welcome.

1 similar comment
@afrittoli
Copy link
Member

Thank you for the fix and welcome.

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@ghost
Copy link

ghost commented May 8, 2020

thanks @plumpy !

/lgtm

@tekton-robot tekton-robot assigned ghost May 8, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@tekton-robot tekton-robot merged commit 9e0229e into tektoncd:master May 8, 2020
@bobcatfish
Copy link
Collaborator

image

@plumpy plumpy deleted the patch-1 branch June 5, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants