Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the sha for the nop image #2713

Merged
merged 1 commit into from
May 29, 2020
Merged

Change the sha for the nop image #2713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ spec:
"-build-gcs-fetcher-image", "github.com/tektoncd/pipeline/vendor/github.com/GoogleCloudPlatform/cloud-builders/gcs-fetcher/cmd/gcs-fetcher",

# These images are pulled from Dockerhub, by digest, as of May 19, 2020.
"-nop-image", "tianon/true@sha256:183cb5fd54142948ad88cc986a217465cfe8786cfdd89b1ed1fc49825da413a7",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting to me -- this digest can't have worked previously, because this is the digest of the image config, not an image manifest (unless Docker somehow does something clever when given a config object digest? but I don't think it does):

digest: sha256:009cce421096698832595ce039aa13fa44327d96beedb84282a69d3dbcf5a81b
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
   "config": {
      "mediaType": "application/vnd.docker.container.image.v1+json",
      "size": 1511,
      "digest": "sha256:183cb5fd54142948ad88cc986a217465cfe8786cfdd89b1ed1fc49825da413a7"
   },
   "layers": [
      {
         "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
         "size": 147,
         "digest": "sha256:c53fb220cbad89d19e819673ea42ffcb938319825ef36f1b96df37af3d4665f5"
      }
   ]
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh… interesting… for some reason I managed to download this image (I do not remember if it was using docker, podman or skopeo lol.. 🤦‍♂️). But that explain why it fails, mystery solved I'ld say.. (I also may have messed up when updating it… I need to proper check how I did it…)

Copy link

@manishtomar manishtomar Jun 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info @tianon. This explains why it is not working but it should still return 404 instead of 500. We will investigate internally depending on priority.

# As of May 29, 2020 new sha for nop image
"-nop-image", "tianon/true@sha256:009cce421096698832595ce039aa13fa44327d96beedb84282a69d3dbcf5a81b",
# This is google/cloud-sdk:293.0.0-slim
"-gsutil-image", "google/cloud-sdk@sha256:37654ada9b7afbc32828b537030e85de672a9dd468ac5c92a36da1e203a98def",
# The shell image must be root in order to create directories and copy files to PVCs.
Expand Down