Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update knative.dev/pkg #2721

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Update knative.dev/pkg #2721

merged 3 commits into from
Jun 3, 2020

Conversation

mattmoor
Copy link
Member

This pulls forward the deps to 0.15

WIP until #2712 lands.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2020
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 30, 2020
@tekton-robot
Copy link
Collaborator

Hi @mattmoor. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

3 similar comments
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@mattmoor
Copy link
Member Author

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 30, 2020
@mattmoor
Copy link
Member Author

/ok-to-test

@tekton-robot
Copy link
Collaborator

@mattmoor: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2020
@ghost
Copy link

ghost commented Jun 1, 2020

Does this dep update introduce any ConfigMaps or Secrets that we need to account for as part of Pipeline's RBAC?

@mattmoor
Copy link
Member Author

mattmoor commented Jun 1, 2020

@sbwsg it should not

@mattmoor mattmoor force-pushed the update-pkg branch 2 times, most recently from 7185486 to 40b7385 Compare June 1, 2020 22:35
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 1, 2020
@mattmoor mattmoor changed the title [WIP] Update knative.dev/pkg Update knative.dev/pkg Jun 1, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Jun 1, 2020

/assign @vdemeester @imjasonh

@imjasonh
Copy link
Member

imjasonh commented Jun 1, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2020
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Jun 2, 2020

ok, this is RFAL. macOS's case insensitive filesystem caused issues with shoulder.md -> SHOULDER.md 🙄

@mattmoor
Update knative to 0.15
79736a3 
Fixup script and run genreocnciler for Tekton types.
@vdemeester
Copy link
Member

/test pull-tekton-pipeline-integration-tests

vdemeester
vdemeester approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Jun 2, 2020

/retest

@mattmoor
Copy link
Member Author

mattmoor commented Jun 2, 2020

@imjasonh This needs another LGTM 😞

@afrittoli
Copy link
Member

@mattmoor Is it worth adding release notes?

@afrittoli
Copy link
Member

Thanks for this @mattmoor !
If I understand this correctly, we generate the controllers now and but still not use them.

I've been looking at the new controllers from knative/pkg, I think most of it is a good fit for Tekton, but it will take a bit of work to integrate them. So I wonder if we should only generated them once we start using them?

@mattmoor
Copy link
Member Author

mattmoor commented Jun 2, 2020

Is it worth adding release notes?

For this alone, I don't think so. I am looking at picking up some of the stuff we've landed (e.g. generated reconcilers), but that's going to take some doing.

So I wonder if we should only generated them once we start using them?

I could go either way on this. I opted for this because script changes were needed for it to work and I had to dig around to find this patch from the last time I sat down to do this (thanks to @n3wscott for the help back then).

I could ofc keep the script changes and drop the // +genreconciler for now, but I wanted to make sure it worked.

@vdemeester
Copy link
Member

I could ofc keep the script changes and drop the // +genreconciler for now, but I wanted to make sure it worked.

We may want to do that, wait for 0.13 to be done / "branched out" (later this week) and add them back 👼

@mattmoor
Copy link
Member Author

mattmoor commented Jun 2, 2020

New commit with changed timestamp, starting a thread on the codegen stuff.

@mattmoor
Copy link
Member Author

mattmoor commented Jun 2, 2020

@vdemeester rerunning codegen now 😇

@mattmoor
Copy link
Member Author

mattmoor commented Jun 2, 2020

Ok, should be RFAL!

@vdemeester
Copy link
Member

/cc @sbwsg @bobcatfish
It would be nice to have this one before 0.13 😝

@tekton-robot tekton-robot requested a review from a user June 2, 2020 16:41
@afrittoli
Copy link
Member

Ok, should be RFAL!

RFAL?

afrittoli
afrittoli reviewed Jun 2, 2020
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Looking forward to integrated the new generated controllers in.
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Jun 3, 2020

/retest
RFAL = Ready For A Look (sorry, I love my acronyms)

@tekton-robot tekton-robot merged commit 524e467 into tektoncd:master Jun 3, 2020
@danielhelfand danielhelfand mentioned this pull request Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@vdemeester vdemeester

@imjasonh imjasonh

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattmoor @tekton-robot @afrittoli @imjasonh @vdemeester