Add pipeline artifact config to the shared config store

[afrittoli]

Changes

The pipeline controller loads the artifact storage config maps via
the client on every reconcile. Refactor the artifact storage code
to extract the configuration aspects and move them into the shared
storage.

Update the artifact storage to use config from the store.
Since the artifact storage interface changed as a consequence,
update all the consumers accordingly: input and out resources
and the task run controller.

Depends-on: #2938

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

/kind cleanup

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1beta1/pipeline.go	82.1%	81.2%	-1.0
pkg/artifacts/artifacts_storage.go	80.2%	82.2%	2.0
pkg/reconciler/taskrun/resources/input_resources.go	89.5%	90.9%	1.4
pkg/reconciler/taskrun/resources/output_resource.go	87.5%	89.1%	1.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1beta1/pipeline.go	82.1%	81.2%	-1.0
pkg/artifacts/artifacts_storage.go	80.2%	82.2%	2.0
pkg/reconciler/pipelinerun/pipelinerun.go	85.9%	86.0%	0.0
pkg/reconciler/taskrun/resources/input_resources.go	89.5%	90.9%	1.4
pkg/reconciler/taskrun/resources/output_resource.go	87.5%	89.1%	1.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1beta1/pipeline.go	82.1%	81.2%	-1.0
pkg/artifacts/artifacts_storage.go	80.2%	82.2%	2.0
pkg/reconciler/pipelinerun/pipelinerun.go	85.9%	86.0%	0.0
pkg/reconciler/taskrun/resources/input_resources.go	89.5%	90.9%	1.4
pkg/reconciler/taskrun/resources/output_resource.go	87.5%	89.1%	1.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1beta1/pipeline.go	82.1%	81.2%	-1.0
pkg/artifacts/artifacts_storage.go	80.2%	82.2%	2.0
pkg/reconciler/pipelinerun/pipelinerun.go	85.9%	86.0%	0.0
pkg/reconciler/taskrun/resources/input_resources.go	89.5%	90.9%	1.4
pkg/reconciler/taskrun/resources/output_resource.go	87.5%	89.1%	1.6

[dlorenc]

You might be able to save some of these checks with the helpers in knative/pkg/configmap:

cm.AsString(BucketLocationKey, &tc.Location)

[afrittoli]

I will check those out, thanks. I could update all config modules together in a separate patch.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1beta1/pipeline.go	82.1%	81.2%	-1.0
pkg/artifacts/artifacts_storage.go	80.2%	82.2%	2.0
pkg/reconciler/taskrun/resources/input_resources.go	89.5%	90.9%	1.4
pkg/reconciler/taskrun/resources/output_resource.go	87.5%	89.1%	1.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1beta1/pipeline.go	82.1%	81.2%	-1.0
pkg/artifacts/artifacts_storage.go	80.2%	82.2%	2.0
pkg/reconciler/pipelinerun/pipelinerun.go	85.9%	86.0%	0.0
pkg/reconciler/taskrun/resources/input_resources.go	89.5%	90.9%	1.4
pkg/reconciler/taskrun/resources/output_resource.go	87.5%	89.1%	1.6

[afrittoli]

/cc @jlpettersson

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/artifacts_storage.go	80.2%	82.2%	2.0
pkg/reconciler/taskrun/resources/input_resources.go	89.5%	90.9%	1.4
pkg/reconciler/taskrun/resources/output_resource.go	87.5%	89.1%	1.6

[tekton-robot]

@afrittoli: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/artifacts/artifacts_storage.go	80.2%	82.2%	2.0
pkg/reconciler/taskrun/resources/input_resources.go	89.5%	90.9%	1.4
pkg/reconciler/taskrun/resources/output_resource.go	87.5%	89.1%	1.6

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment