Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some code in artifact storage. #2965

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Cleanup some code in artifact storage. #2965

merged 1 commit into from
Aug 5, 2020

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jul 19, 2020

Changes

  • We had some constants in two locations - this removes/dedupes these.
  • We were doing some unusual string pointer manipulation- this cleans it up
    a bit and adds some comments explaining why.
  • Minor cleanups around set manipulation.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 19, 2020
@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 19, 2020

/kind cleanup

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 19, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/storage/storage.go 95.2% 95.5% 0.2
pkg/artifacts/artifacts_storage.go 80.2% 80.0% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/storage/storage.go 95.2% 95.5% 0.2
pkg/artifacts/artifacts_storage.go 80.2% 80.0% -0.2

@afrittoli
Copy link
Member

afrittoli commented Jul 19, 2020 •
edited
Loading

I have a PR that does some cleanup work in this area #2947 but I think the changes you proposed here still apply.

@afrittoli
Copy link
Member

/test pull-tekton-pipeline-build-tests

1 similar comment
@afrittoli
Copy link
Member

/test pull-tekton-pipeline-build-tests

@tekton-robot
Copy link
Collaborator

@dlorenc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2020
@dlorenc
Copy link
Contributor Author

dlorenc commented Aug 3, 2020

Thanks for clarifying @afrittoli ! I'll get this cleaned up/rebased.

@dlorenc dlorenc force-pushed the storage_clean branch 2 times, most recently from dc0c2b9 to c85730d Compare August 3, 2020 19:42
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/storage/storage.go 95.2% 95.5% 0.2

@dlorenc dlorenc removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2020
@dlorenc
Cleanup some code in artifact storage.
b4f3efd 
- We had some constants in two locations - this removes/dedupes these.
- We were doing some unusual string pointer manipulation- this cleans it up
a bit and adds some comments explaining why.
- Minor cleanups around set manipulation.
@dlorenc
Copy link
Contributor Author

dlorenc commented Aug 4, 2020

Fixed a comment typo.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/storage/storage.go 95.2% 95.5% 0.2

@dibyom
Copy link
Member

dibyom commented Aug 4, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@tekton-robot tekton-robot merged commit 666e5d1 into tektoncd:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlorenc @tekton-robot @afrittoli @dibyom