Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump controller's required image versions #3002

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Bump controller's required image versions #3002

merged 1 commit into from
Aug 18, 2020

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jul 24, 2020 •
edited
Loading

Changes

  • google/cloud-sdk: 302.0.0-slim

follow-up of #2999

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Bump controller's image 
- nginx: 1.19.1
- google/cloud-sdk: 302.0.0-slim

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 24, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2020
@vdemeester
Copy link
Member Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 24, 2020
@dlorenc
Copy link
Contributor

dlorenc commented Jul 24, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@pritidesai
Copy link
Member

I verified the hashes but trying to understand why and how we change this versioning? any guidelines? 🤔 😉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@vdemeester
Copy link
Member Author

I verified the hashes but trying to understand why and how we change this versioning? any guidelines? thinking wink

We need some I think. In the ideal world, we would have a cron job somewhere that checks new version and open a PR if new 😝

@dlorenc
Copy link
Contributor

dlorenc commented Jul 25, 2020

Looks like an issue with EasyCLA... This PR is stuck in the merge pool holding everything else up.

EasyCLA Expected — Waiting for status to be reported

@dlorenc dlorenc added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2020
@vdemeester vdemeester removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@vdemeester
Copy link
Member Author

Removing lgtm to unblock the merge queue, I'll re-push to fix easycla

@vdemeester vdemeester force-pushed the bump-image-digests branch from 2bf002d to 21da443 Compare July 27, 2020 08:09
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2020
@afrittoli afrittoli added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Aug 2, 2020
@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@afrittoli afrittoli added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Aug 2, 2020
@afrittoli
Copy link
Member

We don't use nginx anymore, so this needs to be updated.
Since this was approved already, I'll take the liberty of resolving the conflict and merging, so we can get the new gcloud image version in v0.15

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2020
@vdemeester vdemeester added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Aug 4, 2020
@chmouel
Copy link
Member

chmouel commented Aug 4, 2020

/lgtm

Looking Good! 🤙🏽

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2020
@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@vdemeester vdemeester added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Aug 4, 2020
@dibyom
Copy link
Member

dibyom commented Aug 4, 2020

/test pull-tekton-pipeline-integration-tests

@vdemeester
Copy link
Member Author

/hold
The failure are legit (and might be related to pullrequest permission issue on 0.15.0)

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2020
@vdemeester vdemeester mentioned this pull request Aug 5, 2020
Closed
@vdemeester
Copy link
Member Author

/lgtm cancel

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
@vdemeester
Bump controller's required image versions
4172bdd 
- google/cloud-sdk: 302.0.0-slim

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester
Copy link
Member Author

/hold cancel
Removing gcr.io/distroless/base:debug-nonroot change to get this in. Will do a follow-up to try to fix #3048.

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2020
@vdemeester vdemeester added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Aug 18, 2020
@pradeepitm12
Copy link

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@tekton-robot tekton-robot merged commit 86d3306 into tektoncd:master Aug 18, 2020
@vdemeester vdemeester deleted the bump-image-digests branch August 18, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@chmouel chmouel

@dlorenc dlorenc

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vdemeester @dlorenc @pritidesai @tekton-robot @afrittoli @chmouel @dibyom @pradeepitm12