Add omitempty for SchedulerName, ImagePullSecrets, HostNetwork

[danielhelfand]

Changes

This pull request adds omitempty for the following pod template fields:

• SchedulerName
• ImagePullSecrets
• HostNetwork

As documented in #17, SchedulerName and HostNetwork are designated as optional fields and as such should be omitted if not declared. Why ImagePullSecrets is not considered optional seems interesting to me, and perhaps should be discussed a bit further before being introduced. But overall, it might have been overlooked when introducing #2547.

Please let me know if there should be further discussions with regard to this being a breaking change.

Submitter Checklist

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Omit SchedulerName, HostNetwork, and ImagePullSecrets if not declared for PodTemplate

[danielhelfand]

/kind bug

[imjasonh]

/lgtm

This doesn't qualify as a breaking change because users shouldn't have been depending on specifics like "" being returned in JSON responses from the server.

[danielhelfand]

/lgtm

This doesn't qualify as a breaking change because users shouldn't have been depending on specifics like "" being returned in JSON responses from the server.

Thanks for the clarification. I guess my concern is more about the request for developers working around the API. Those fields are included even when not declared (e.g., when I tried to introduce pod template support in tkn). That being said, I would consider that to be unexpected.

[jlpettersson]

/lgtm

[pritidesai]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [pritidesai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment