Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the nop image to the nightly pipeline release #3041

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Add the nop image to the nightly pipeline release #3041

merged 1 commit into from
Aug 3, 2020

Conversation

afrittoli
Copy link
Member

Changes

The nop image has been added to the full release task and pipeline, but it was still missing in the nightly
release pipeline, so adding it now.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a] Includes tests (if functionality changed/added)
  • [n/a] Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

The `nop` image, used by the affinity assistant as well as to terminate sidecars, is now part of nightly builds.

/kind misc
/cc @imjasonh

@tekton-robot tekton-robot requested a review from imjasonh August 2, 2020 10:15
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2020
@imjasonh
Copy link
Member

imjasonh commented Aug 2, 2020

/lgtm

Thanks! Do we have a checklist of places where new images need to be configured? The PR template reminder only mentions the one location, and there are (apparently) 4?

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2020
@afrittoli
Copy link
Member Author

/lgtm

Thanks! Do we have a checklist of places where new images need to be configured? The PR template reminder only mentions the one location, and there are (apparently) 4?

Good point, I don't think we do...

vdemeester
vdemeester approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
@tekton-robot tekton-robot merged commit a1af40d into tektoncd:master Aug 3, 2020
nikhil-thomas added a commit to nikhil-thomas/plumbing that referenced this pull request Aug 3, 2020
@nikhil-thomas
Add nop-image resource to pipline trigger template
eb5fb28 
Add nop-image resource to pipelinerun as the referred pipeline has a new
`builtNopImage` param (tektoncd/pipeline#3041)

Signed-off-by: Nikhil Thomas <[email protected]>
@nikhil-thomas nikhil-thomas mentioned this pull request Aug 3, 2020
Merged
2 tasks
nikhil-thomas added a commit to nikhil-thomas/plumbing that referenced this pull request Aug 3, 2020
@nikhil-thomas
Add nop-image resource to pipline trigger template
f398d5a 
Add nop-image resource to pipelinerun as the referred pipeline has a new
`builtNopImage` param (tektoncd/pipeline#3041)

Signed-off-by: Nikhil Thomas <[email protected]>
tekton-robot pushed a commit to tektoncd/plumbing that referenced this pull request Aug 3, 2020
@nikhil-thomas @tekton-robot
Add nop-image resource to pipline trigger template
f137034 
Add nop-image resource to pipelinerun as the referred pipeline has a new
`builtNopImage` param (tektoncd/pipeline#3041)

Signed-off-by: Nikhil Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afrittoli @imjasonh @tekton-robot @vdemeester