Update Docker Desktop setup and separate out MiniKube setup #3065
Conversation
This PR seeks to separate out the MiniKube setup which somehow appears to have been placed under the Docker Desktop setup instructions. While doing this I thought to update the instructions to be more accurate relative to the Docker Desktop preferences and menuing system.
tekton-robot
added
the
release-note
tekton-robot
added
size/M
|
Hi @mrutkows. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Please note that I did not intend to fix the Minikube instructions (as I do not use it); however, it appears that recently some quite extensive (and perhaps overkill as the pre-req development tools) instructions were added to which seem to me to be more suited for DEVELOPMENT.md ... |
|
/kind documentation |
tekton-robot
added
kind/documentation
|
|
||
| 1. Switch the proper `kubectl` config context: | ||
|
|
||
| ```bash | ||
| kubectl config get-contexts # You should see docker-for-desktop in the previous command output | ||
| kubectl config use-context docker-for-desktop | ||
| ``` | ||
| * *Note: Docker Desktop menu provides a `Kubernetes` menuitem that allows you to select between contexts which is equivalent to the `kubectl` command.* |
There was a problem hiding this comment.
thanks @mrutkows for fixing the section header and adding details on Docker Desktop 🙏
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
This PR seeks to separate out the MiniKube setup which somehow appears to have been placed under the Docker Desktop setup instructions. While doing this I thought to update the instructions to be more accurate relative to the Docker Desktop preferences and menuing system.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes