Allow skipping some YAML tests #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
chmouel
force-pushed
the
alow-skipping-tests
branch
3 times, most recently
from
170070b to
f9617a6
Compare
tekton-robot
added
kind/misc
Allow skipping some of the yaml tests if the environment variable TEST_EXAMPLES_IGNORES is set and match the regexp : For example : export TEST_EXAMPLES_IGNORES=".*clustertasks.*" will skip all the kankiko examples yamls. Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel
force-pushed
the
alow-skipping-tests
branch
from
f9617a6 to
7b36913
Compare
dlorenc
reviewed
Aug 7, 2020
tekton-robot
added
do-not-merge/release-note-label-needed
dlorenc
reviewed
Aug 7, 2020
|
/lgtm |
dlorenc
reviewed
Aug 14, 2020
| re := regexp.MustCompile(val) | ||
| submatch := re.FindSubmatch([]byte(path)) | ||
| if submatch != nil { | ||
| t.Logf("Skipping test %s", path) |
There was a problem hiding this comment.
@dlorenc it would skip all the tests I think 🙃
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow skipping some of the yaml tests if the environment variable
TEST_EXAMPLES_IGNORESis set and match the regexp :For example :
export TEST_EXAMPLES_IGNORES=".*clustertasks.*"will skip all the kankiko examples yamls.
We have a need for this because we want to run the go yaml examples testsuite
but need to skip some of those tests that are not compatible with openshift due
of some restrictions on that system.
/kind misc
/area testing
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Note