Validate missing volume configs in Workspace Bindings #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a PipelineRun specifies a Workspace Binding, it is required to submit the volume configuration as part of that Binding. Currently the volume details aren't validated and so a PipelineRun with a Workspace Binding that only includes a "name" field will validate. The end result is that the Workspace is passed to the TaskRun and fails validation there instead. This commit adds validation to PipelineRuns to ensure that any Workspaces passed include some correct volume configuration data.
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
ghost
mentioned this pull request
|
The following is the coverage report on the affected files.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
dlorenc
reviewed
Aug 13, 2020
| "workspace.emptydir", | ||
| "workspace.configmap", | ||
| "workspace.secret", | ||
| "persistentvolumeclaim", |
vdemeester
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Contributes to #3089 but doesn't completely fix it. There's another bug hidden in there that a PipelineRun submitting a TaskRun with invalid workspace is not entering a failed state even though the TaskRun reconciler is loudly complaining about the workspace config.
When a PipelineRun specifies a Workspace Binding, it is required to
submit the volume configuration as part of that Binding. Currently
the volume details aren't validated and so a PipelineRun with a Workspace
Binding that only includes a "name" field will validate. The end
result is that the Workspace is passed to the TaskRun and fails
validation there instead.
This commit adds validation to PipelineRuns to ensure that any
Workspaces passed include some correct volume configuration data.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: