Check that events are at least expected ones #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
ghost
approved these changes
Oct 13, 2020
tekton-robot
added
the
approved
|
/approve cancel sorry i did not see the WIP |
tekton-robot
removed
the
approved
|
/kind bug |
afrittoli
force-pushed
the
issues/3374
branch
from
c0242f5 to
43d7ad1
Compare
afrittoli
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
afrittoli
force-pushed
the
issues/3374
branch
from
43d7ad1 to
7a3b445
Compare
|
/test pull-tekton-pipeline-integration-tests |
pritidesai
reviewed
Oct 13, 2020
This was referenced Oct 13, 2020
afrittoli
force-pushed
the
issues/3374
branch
from
7a3b445 to
037ddf7
Compare
tekton-robot
added
size/M
mattmoor
reviewed
Oct 15, 2020
test/cancel_test.go
Outdated
Comment on lines
174
to
175
| collectedEvents := "" | ||
| for i, event := range events { | ||
| collectedEvents += fmt.Sprintf("%#v", event) | ||
| if i < (len(events) - 1) { | ||
| collectedEvents += ", " | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| collectedEvents := "" | |
| for i, event := range events { | |
| collectedEvents += fmt.Sprintf("%#v", event) | |
| if i < (len(events) - 1) { | |
| collectedEvents += ", " | |
| } | |
| } | |
| collectedEvents := make([]string, 0, len(events)) | |
| for _, event := range events { | |
| collectedEvents = append(collectedEvents, fmt.Sprintf("%#v", event)) | |
| } | |
| ... = strings.Join(collectedEvents, ", ") |
|
@pritidesai @sbwsg it would be good to get this merged, as it keeps causing flakes |
afrittoli
added
the
kind/flake
mattmoor
reviewed
Oct 20, 2020
tekton-robot
added
do-not-merge/hold
afrittoli
force-pushed
the
issues/3374
branch
from
037ddf7 to
e87d05b
Compare
Events are not guaranteed to be sent once, so allow for more than one in the cancel_test. Fixes tektoncd#3374 Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
issues/3374
branch
from
e87d05b to
53c2be5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
|
workspace in sidecar might be the next flake? |
|
/hold cancel As well. |
tekton-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #3374
Signed-off-by: Andrea Frittoli [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes