Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix finally e2e test #3464

Merged
merged 1 commit into from
Oct 29, 2020
Merged

fix finally e2e test #3464

merged 1 commit into from
Oct 29, 2020

Conversation

pritidesai
Copy link
Member

@pritidesai pritidesai commented Oct 28, 2020 •
edited
Loading

Changes

There was a bug in retrieving a list of taskRuns. All the names were instrumented but listing taskruns for a pipelineRun was still using old pipelineRun name which returned an empty list of taskRuns and in turn resulting in skipping all the validations. Fixed the call where all the taskRuns are being retrieved for the pipelineRun. And now since the taskRun names are no longer predictable, iterate over the taskRuns and distinguish them based on the label tekton.dev/pipelineTask.

/kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@pritidesai
fix finally e2e test
700d19c 
There was a bug in retrieving a list of taskRuns. All the names were
instrumented but listing taskruns for a pipelineRun was still using
old pipelineRun name which was causing an empty list of taskRuns and
in turn resulting in skipping all the validations. Fixed the call
where all the taskRuns are being retrieved for the pipelineRun.
And now since the taskRun names are no longer predictable, iterate over
the taskRuns and distinguish them based on the label tekton.dev/pipelineTask.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Oct 28, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2020
@pritidesai
Copy link
Member Author

/cc @mattmoor

@tekton-robot tekton-robot requested a review from mattmoor October 28, 2020 04:28
mattmoor
mattmoor approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020
vdemeester
vdemeester approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@vdemeester
Copy link
Member

/test check-pr-has-kind-label

@pritidesai
Copy link
Member Author

/retest

@pritidesai
Copy link
Member Author

/test check-pr-has-kind-label

2 similar comments
@pritidesai
Copy link
Member Author

/test check-pr-has-kind-label

@vdemeester
Copy link
Member

/test check-pr-has-kind-label

@vdemeester vdemeester added kind/bug Categorizes issue or PR as related to a bug. and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 29, 2020
@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@afrittoli
Copy link
Member

The job is triggered on Tekton side, but I don't see the github update task executed at all, looking into it.

@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@afrittoli
Copy link
Member

The cloud event sink config was missing on tekton side, not sure what happened there...
I redeployed Tekton and it's fine now.

@afrittoli
Copy link
Member

/lgtm

@tekton-robot tekton-robot merged commit b405d86 into tektoncd:master Oct 29, 2020
@pritidesai pritidesai deleted the finally-e2e branch October 29, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@vdemeester vdemeester

@afrittoli afrittoli

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pritidesai @tekton-robot @vdemeester @afrittoli @mattmoor