Remove cluster-wide namespace list/watch permissions #3880
Merged
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permission was previously needed to support how we enforced timeouts, by listing all TaskRuns/PipelineRuns across all namespaces and determining whether they were past their timeout. Since tektoncd#3500 this check was changed to not require listing all namespaces, so I believe the permission is no longer necessary.
tekton-robot
added
release-note
tekton-robot
added
the
size/XS
ghost
approved these changes
Apr 14, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Nice! |
tekton-robot
added
the
approved
|
great find 🎉 /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permission was previously needed to support how we enforced
timeouts, by listing all TaskRuns/PipelineRuns across all namespaces and
determining whether they were past their timeout. Since
#3500 this check was changed
to not require listing all namespaces, so I believe the permission is no
longer necessary.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes